From: Toon Claes <toon@iotcl•com>
To: Karthik Nayak <karthik.188@gmail•com>, git@vger•kernel.org
Cc: ps@pks•im, jltobler@gmail•com, gitster@pobox•com,
Karthik Nayak <karthik.188@gmail•com>
Subject: Re: [PATCH v3] builtin/refs: add '--skip-reflog' flag to bypass reflog migration
Date: Wed, 19 Feb 2025 11:06:05 +0100 [thread overview]
Message-ID: <87a5aiqmeq.fsf@iotcl.com> (raw)
In-Reply-To: <20250212-477-refs-migrate-add-a-flag-to-ignore-reflogs-during-migration-v3-1-98b2c4d2bb0c@gmail.com>
Karthik Nayak <karthik.188@gmail•com> writes:
> The 'git-refs(1)' migrate subcommand, which transfers repositories
> between reference backends, currently migrates reflogs by default as of
> 246cebe320 (refs: add support for migrating reflogs, 2024-12-16).
>
> While this behavior is desirable for most client-side repositories,
> server-side repositories are not expected to contain reflogs. However,
> due to historical reasons, some may still have them. This could be
> caused, for example, by bugs, misconfiguration, or an administrator
> enabling reflogs on the server for debugging purposes.
>
> To address this, introduce the --skip-reflog flag, allowing users to
> bypass reflog migration. This ensures that the repository ends up in the
> expected state after migration.
It wasn't really obvious to me this change removes the reflog, instead
of "skipping". So I was surprised the reflog was removed after
migrating, instead of staying in tact using the files backend.
Only after reading through the test and the discussion in this thread I
realized that's the intented behavior.
So can I suggest to name the option `--no-reflog`? To me that makes it
more obvious the reflog won't exist no more after migrating, and is more
in line with the common UX of Git. Also emphasizing this more clearly in
the commit message and help message also would be advised.
--
Toon
next prev parent reply other threads:[~2025-02-19 10:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 11:57 [PATCH] builtin/refs: add '--skip-reflog' flag to bypass reflog migration Karthik Nayak
2025-02-07 15:23 ` Patrick Steinhardt
2025-02-11 6:18 ` Karthik Nayak
2025-02-07 17:45 ` Justin Tobler
2025-02-11 6:09 ` Karthik Nayak
2025-02-11 11:42 ` [PATCH v2] " Karthik Nayak
2025-02-11 12:21 ` Patrick Steinhardt
2025-02-11 17:48 ` Junio C Hamano
2025-02-12 17:43 ` Karthik Nayak
2025-02-13 9:25 ` Karthik Nayak
2025-02-12 18:38 ` [PATCH v3] " Karthik Nayak
2025-02-12 22:25 ` Junio C Hamano
2025-02-13 9:22 ` Karthik Nayak
2025-02-13 18:06 ` Junio C Hamano
2025-02-14 8:50 ` Karthik Nayak
2025-02-19 10:06 ` Toon Claes [this message]
2025-02-19 17:04 ` Junio C Hamano
2025-02-19 20:28 ` Karthik Nayak
2025-02-19 21:37 ` Junio C Hamano
2025-02-20 10:00 ` Karthik Nayak
2025-02-20 9:56 ` [PATCH v4] builtin/refs: add '--no-reflog' flag to drop reflogs Karthik Nayak
2025-02-20 15:14 ` Junio C Hamano
2025-02-21 8:44 ` Karthik Nayak
2025-02-21 10:04 ` [PATCH v5] " Karthik Nayak
2025-02-21 17:54 ` Junio C Hamano
2025-02-23 20:30 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5aiqmeq.fsf@iotcl.com \
--to=toon@iotcl$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jltobler@gmail$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox