From: Pat Thoyts <patthoyts@users•sourceforge.net>
To: Alexander Shopov <ash@kambanaria•org>
Cc: git@vger•kernel.org
Subject: Re: [GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation
Date: Fri, 14 Oct 2016 01:46:44 +0100 [thread overview]
Message-ID: <87a8e73ggb.fsf@red.patthoyts.tk> (raw)
In-Reply-To: <20161013184349.42950-1-ash@kambanaria.org> (Alexander Shopov's message of "Thu, 13 Oct 2016 21:43:48 +0300")
Alexander Shopov <ash@kambanaria•org> writes:
>Signed-off-by: Alexander Shopov <ash@kambanaria•org>
>---
> lib/remote.tcl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/lib/remote.tcl b/lib/remote.tcl
>index 4e5c784..26af8ae 100644
>--- a/lib/remote.tcl
>+++ b/lib/remote.tcl
>@@ -250,12 +250,12 @@ proc update_all_remotes_menu_entry {} {
>
> $fetch_m insert end separator
> $fetch_m insert end command \
>- -label "All" \
>+ -label [mc "All"] \
> -command fetch_from_all
>
> $prune_m insert end separator
> $prune_m insert end command \
>- -label "All" \
>+ -label [mc "All" ]\
> -command prune_from_all
> }
> } else {
OK - this looks fine except the line just above compares the text of
this entry so also needs [mc] adding. I've applied it as:
-- a/lib/remote.tcl
+++ b/lib/remote.tcl
@@ -246,22 +246,22 @@ proc update_all_remotes_menu_entry {} {
if {$have_remote > 1} {
make_sure_remote_submenues_exist $remote_m
if {[$fetch_m type end] eq "command" \
- && [$fetch_m entrycget end -label] ne "All"} {
+ && [$fetch_m entrycget end -label] ne [mc "All"]} {
$fetch_m insert end separator
$fetch_m insert end command \
- -label "All" \
+ -label [mc "All"] \
-command fetch_from_all
$prune_m insert end separator
$prune_m insert end command \
- -label "All" \
+ -label [mc "All"] \
-command prune_from_all
}
} else {
if {[winfo exists $fetch_m]} {
if {[$fetch_m type end] eq "command" \
- && [$fetch_m entrycget end -label] eq "All"} {
+ && [$fetch_m entrycget end -label] eq [mc "All"]} {
delete_from_menu $fetch_m end
delete_from_menu $fetch_m end
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
prev parent reply other threads:[~2016-10-14 0:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 18:43 [GIT GUI l18n 1/2] git-gui: Mark 'All' in remote.tcl for translation Alexander Shopov
2016-10-14 0:46 ` Pat Thoyts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8e73ggb.fsf@red.patthoyts.tk \
--to=patthoyts@users$(echo .)sourceforge.net \
--cc=ash@kambanaria$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox