From: Thomas Rast <trast@inf•ethz.ch>
To: Ralf Thielow <ralf.thielow@gmail•com>
Cc: "Christian Stimming" <stimming@tuhh•de>, "Jan Krüger" <jk@jk•gs>,
git <git@vger•kernel.org>
Subject: Re: [PATCH/RFC] l10n: de.po: translate 39 new messages
Date: Wed, 17 Apr 2013 10:09:29 +0200 [thread overview]
Message-ID: <87a9ox1sue.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <CAN0XMOLmwUpwOi0xz4iOy3wfhzCeeNKNgywgS9ZfaET172vsBQ@mail.gmail.com> (Ralf Thielow's message of "Wed, 17 Apr 2013 07:14:10 +0200")
Ralf Thielow <ralf.thielow@gmail•com> writes:
> Hi,
>
> Thanks for review!
>
> On Mon, Apr 15, 2013 at 9:26 PM, Christian Stimming <stimming@tuhh•de>wrote:
>
>> Thanks for the regular update! This is great work.
>>
>> One issue with the plural form messages, though:
>>
>> Am Montag, 15. April 2013, 18:27:40 schrieb Ralf Thielow:
>> > #: bundle.c:186
>> > -#, fuzzy, c-format
>> > +#, c-format
>> > msgid "The bundle contains this ref:"
>> > msgid_plural "The bundle contains these %d refs:"
>> > -msgstr[0] "Das Paket enthält %d Referenz"
>> > -msgstr[1] "Das Paket enthält %d Referenzen"
>> > +msgstr[0] "Das Paket enthält diese Referenz:"
>> > +msgstr[1] "Das Paket enthält diese %d Referenzen:"
>>
>> The msgstr[0] must still contain a %d conversion specifier (which will be
>> filled with the number 1) even though the translated sentence wouldn't need
>> the 1 anymore. The previous msgstr[0] was correct; the English singular
>> msgid
>> is not.
>>
> That made me wonder, too. I've played around a bit with this, and it seems
> to be OK as long as one of those strings contain at least one format
> specifier.
C printf() only knows about the number and types of arguments from the
format string, so *ignoring* arguments is not a problem for correctness.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-04-17 8:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 16:27 [PATCH/RFC] l10n: de.po: translate 39 new messages Ralf Thielow
2013-04-15 19:26 ` Christian Stimming
2013-04-17 5:18 ` Ralf Thielow
[not found] ` <CAN0XMOLmwUpwOi0xz4iOy3wfhzCeeNKNgywgS9ZfaET172vsBQ@mail.gmail.com>
2013-04-17 8:09 ` Thomas Rast [this message]
2013-04-17 15:35 ` Christian Stimming
2013-04-17 23:02 ` Junio C Hamano
2013-04-16 8:34 ` Thomas Rast
2013-04-17 5:49 ` Ralf Thielow
2013-04-17 7:50 ` Thomas Rast
2013-04-18 17:14 ` [PATCHv2] " Ralf Thielow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9ox1sue.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf$(echo .)ethz.ch \
--cc=git@vger$(echo .)kernel.org \
--cc=jk@jk$(echo .)gs \
--cc=ralf.thielow@gmail$(echo .)com \
--cc=stimming@tuhh$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox