Subject: Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests

From: Thomas Rast <[email-masked]>
Date: Mon, 5 Mar 2012 08:53:39 +0100

[email-masked] writes:

> +# GIT_VALGRIND_TOOLS is the location of tools like valgrind.sh.
> +if test -z "$GIT_VALGRIND_TOOLS"
> +then
> +	# We allow tests to override this, in case they want to run tests
> +	# outside of t/.
> + 
> +        # For in-tree test scripts, this is in TEST_DIRECTORY/valgrind
> +        # (t/valgrind), but a test script that lives outside t/ can
> +        # set this variable to point at the right place so that it can
> +        # find t/valgrind directory that house test helpers like
> +        # valgrind.sh.
> +       GIT_VALGRIND_TOOLS="$TEST_DIRECTORY"/valgrind
> +fi

I'm a bit curious: why isn't it enough to spell that path
$GIT_BUILD_DIR/t/valgrind instead of making it fully configurable?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch