public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Toon Claes <toon@iotcl•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: Patrick Steinhardt <ps@pks•im>, git@vger•kernel.org
Subject: Re: [PATCH v2 2/2] t0450: add allowlist for builtins with missing .adoc
Date: Wed, 03 Sep 2025 13:26:05 +0200	[thread overview]
Message-ID: <87bjnrg4ky.fsf@iotcl.com> (raw)
In-Reply-To: <xmqq5xe0incd.fsf@gitster.g>

--text follows this line--
Junio C Hamano <gitster@pobox•com> writes:

> Toon, did you have a chance to take a look at Patrick's update?  Can
> we move forward by squashing it into your [2/2]?

Hi Junio,

Yes, I've reviewed the changes, and they look good to me. I like the
code more than the /clever/ approach I was attempting. My code succeeded
on my machine, but it didn't on CI (sorry, I only saw that too late, I
was rushing into my time off).

Thanks both!

--
Toon

next prev parent reply	other threads:[~2025-09-03 11:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04  7:30 [PATCH] t0450: fix test for out-of-tree builds Toon Claes
2025-08-04  7:56 ` Patrick Steinhardt
2025-08-05 12:11   ` Toon Claes
2025-08-08  9:59 ` [PATCH v2 0/2] Harden test t0450-txt-doc-vs-help Toon Claes
2025-08-08  9:59 ` [PATCH v2 1/2] t0450: fix test for out-of-tree builds Toon Claes
2025-08-08  9:59 ` [PATCH v2 2/2] t0450: add allowlist for builtins with missing .adoc Toon Claes
2025-08-08 22:07   ` Junio C Hamano
2025-08-12 12:52     ` Patrick Steinhardt
2025-08-28 23:12       ` Junio C Hamano
2025-09-02 20:57         ` Junio C Hamano
2025-09-03 11:26           ` Toon Claes [this message]
2025-09-03 18:46             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjnrg4ky.fsf@iotcl.com \
    --to=toon@iotcl$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=ps@pks$(echo .)im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox