From: David Kastrup <dak@gnu•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: Siddharth Goel <siddharth98391@gmail•com>,
git@vger•kernel.org, sunshine@sunshineco•com
Subject: Re: [PATCH v3] skip_prefix: rewrite so that prefix is scanned once
Date: Tue, 04 Mar 2014 00:22:15 +0100 [thread overview]
Message-ID: <87bnxmkguw.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <xmqq61nuoqd5.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 03 Mar 2014 14:43:18 -0800")
Junio C Hamano <gitster@pobox•com> writes:
> --- a/git-compat-util.h
> +++ b/git-compat-util.h
> @@ -357,8 +357,14 @@ extern int suffixcmp(const char *str, const char *suffix);
>
> static inline const char *skip_prefix(const char *str, const char *prefix)
> {
> - size_t len = strlen(prefix);
> - return strncmp(str, prefix, len) ? NULL : str + len;
> + while (1) {
> + if (!*prefix)
> + return str;
> + if (*str != *prefix)
> + return NULL;
> + prefix++;
> + str++;
> + }
> }
How about a function body of
do {
if (!*prefix)
return str;
} while (*str++ == *prefix++);
return NULL;
I'm not too fond of while (1) and tend to use for (;;) instead, but that
may again partly be due to some incredibly non-optimizing compiler back
in the days of my youth. At any rate, the do-while loop seems a bit
brisker.
--
David Kastrup
next prev parent reply other threads:[~2014-03-03 23:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 3:13 [PATCH v3] skip_prefix: rewrite so that prefix is scanned once Siddharth Goel
2014-03-03 19:05 ` Junio C Hamano
2014-03-03 22:43 ` Junio C Hamano
2014-03-03 23:22 ` David Kastrup [this message]
2014-03-03 23:35 ` Junio C Hamano
2014-03-03 23:37 ` Duy Nguyen
2014-03-04 0:09 ` David Kastrup
2014-03-04 1:58 ` Duy Nguyen
2014-03-04 9:18 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnxmkguw.fsf@fencepost.gnu.org \
--to=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=siddharth98391@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox