Subject: Re: [PATCH 03/13] contrib/subtree: Better Error Handling for add

From: Andreas Schwab <[email-masked]>
Date: Fri, 02 Aug 2013 10:19:16 +0200

"David A. Greene" <[email-masked]> writes:

>  	elif [ $# -eq 2 ]; then
> -		"cmd_add_repository" "$@"
> +	    git rev-parse -q --verify "$2^{commit}" >/dev/null ||
> +	    die "'$2' does not refer to a commit"

That doesn't make any sense.  $2 is a commit in a remote repository
which hasn't been fetched yet, so it can never be verified against the
local repository.

Andreas.

-- 
Andreas Schwab, [email-masked]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."