From: l.stelmach@samsung•com (Łukasz Stelmach)
To: git@vger•kernel.org
Subject: Re: [PATCH] send-email: support NNTP
Date: Wed, 24 Apr 2013 10:42:44 +0200 [thread overview]
Message-ID: <87bo94720r.fsf@samsung.com> (raw)
In-Reply-To: 87zjwofken.fsf@linux-k42r.v.cablecom.net
It was <2013-04-24 śro 09:38>, when Thomas Rast wrote:
> Łukasz Stelmach <l.stelmach@samsung•com> writes:
>
>> Enable sending patches to NNTP servers (Usenet, Gmane).
>
> I'm surprised Junio didn't mention this: your patch lacks the
> Signed-off-by.
>
>> + if ($email_protocol eq 'nntp') {
>> + $header = "Newsgroups: $to\n" . $header;
>> + } else {
>> + $header = "To: $to${ccline}\n" . $header;
>> + }
>
> Are you silently ignoring any Ccs that have been set if you're in NNTP
> mode?
Yes.
> Would it be possible to instead send the Ccs by mail as usual, and only
> the main message over NNTP? (You don't need to run off and implement
> this, but I'm curious how hard you think it would be.)
Currently you choose a code path with --protocol. The message is sent
only once. It is possible to iterate over To/Cc/Bcc/Newsgroups and
choose send it more than once. There are some tiny nasty bits though, I
don't know how to handle. For example:
--8<---------------cut here---------------start------------->8---
@@ -761,12 +807,21 @@ if (!defined $sender) {
}
my $prompting = 0;
-if (!@initial_to && !defined $to_cmd) {
+
+if ($email_protocol eq 'smtp' && !@initial_to && !defined $to_cmd) {
my $to = ask("Who should the emails be sent to (if any)? ",
default => "",
valid_re => qr/\@.*\./, confirm_only => 1);
push @initial_to, parse_address_line($to) if defined $to; # sanitized/validated later
$prompting++;
+} elsif ($email_protocol eq 'nntp' &&
+ !@initial_newsgroups &&
+ !defined $newsgroups_cmd) {
+ my $newsgroup = ask("Which newsgroups should the message be sent to (if any)? ",
+ default => "",
+ valid_re => qr/[\x20-\x7f]+/, confirm_only => 1);
+ push @initial_newsgroups, $newsgroup if defined $newsgroup; # sanitized/validated later
+ $prompting++;
}
--8<---------------cut here---------------end--------------->8---
How to ask interactively where to send the message? With protocol set
early it is clear what we are trying to do. Any suggestions?
The other issue is that I am not sure (RFC?) if it is OK to send
To/Cc/Bcc headers in a NNTP message. Theoretically they should not break
things but...
> At least in the git@vger world with a lot of etiquette surrounding the
> use of Ccs, NNTP mode isn't very useful if you can't also send Ccs. But
> maybe you have another use-case where that is not a problem?
I've sent this patch vi NNTP :) You've got it.
--
Łukasz Stelmach
Software wizzard
Samsung Poland R&D Center
next prev parent reply other threads:[~2013-04-24 8:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 11:13 [PATCH] send-email: support NNTP Łukasz Stelmach
2013-04-23 15:02 ` Junio C Hamano
2013-04-24 7:31 ` Łukasz Stelmach
2013-04-24 16:17 ` Junio C Hamano
2013-04-25 6:56 ` Łukasz Stelmach
2013-04-25 16:54 ` Junio C Hamano
2013-04-25 17:35 ` Junio C Hamano
2013-04-24 7:19 ` Eric Sunshine
2013-04-24 7:30 ` Łukasz Stelmach
2013-04-24 7:38 ` Thomas Rast
2013-04-24 8:42 ` Łukasz Stelmach [this message]
2013-04-24 9:29 ` Thomas Rast
2013-04-24 22:41 ` Junio C Hamano
2013-04-25 7:02 ` Łukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bo94720r.fsf@samsung.com \
--to=l.stelmach@samsung$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox