From: Thomas Rast <trast@inf•ethz.ch>
To: Jeff King <peff@peff•net>
Cc: John Keeping <john@keeping•me.uk>, <git@vger•kernel.org>
Subject: Re: [PATCH] t/test-lib.sh: fix TRASH_DIRECTORY handling
Date: Sun, 14 Apr 2013 21:44:36 +0200 [thread overview]
Message-ID: <87d2twzyl7.fsf@hexa.v.cablecom.net> (raw)
In-Reply-To: <20130414193821.GC4599@sigill.intra.peff.net> (Jeff King's message of "Sun, 14 Apr 2013 15:38:21 -0400")
Jeff King <peff@peff•net> writes:
> On Sun, Apr 14, 2013 at 05:34:56PM +0100, John Keeping wrote:
>
>> After the location of $TRASH_DIRECTORY is adjusted by
>> $TEST_OUTPUT_DIRECTORY, we go on to use the $test variable to make the
>> trash directory and cd into it. This means that when
>> $TEST_OUTPUT_DIRECTORY is not "." and an absolute --root has not been
>> specified, we do not remove the trash directory once the tests are
>> complete (remove_trash is set to $TRASH_DIRECTORY).
>>
>> Fix this by always referring to the trash directory as $TRASH_DIRECTORY.
>
> Thanks, this seems to date back all the way to my f423ef5 (tests: allow
> user to specify trash directory location, 2009-08-09), although I think
> at that time it was not even possible to run the tests from any other
> directory. So I am happy to blame Thomas's later patches for violating
> my assumptions. :)
>
> Definitely:
>
> Acked-by: Jeff King <peff@peff•net>
Indeed, your blame assignment seems correct :-)
Acked-by: Thomas Rast <trast@inf•ethz.ch>
> -- >8 --
> Subject: [PATCH] t/test-lib.sh: drop "$test" variable
>
> The $test variable is used as an interim buffer for
> constructing $TRASH_DIRECTORY, and is almost compatible with
> it (the exception being that $test has not been converted to
> an absolute path). Let's get rid of it entirely so that
> later code does not accidentally use it, thinking the two
> are interchangeable.
Agreed.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2013-04-14 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-14 16:34 [PATCH] t/test-lib.sh: fix TRASH_DIRECTORY handling John Keeping
2013-04-14 19:38 ` Jeff King
2013-04-14 19:44 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2twzyl7.fsf@hexa.v.cablecom.net \
--to=trast@inf$(echo .)ethz.ch \
--cc=git@vger$(echo .)kernel.org \
--cc=john@keeping$(echo .)me.uk \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox