From: "David Kågedal" <davidk@lysator•liu.se>
To: Alexandre Julliard <julliard@winehq•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] git.el: Only show completions from refs/heads, refs/remotes and refs/tags
Date: Tue, 24 Feb 2009 09:42:18 +0100 [thread overview]
Message-ID: <87d4d8usyd.fsf@krank.kagedal.org> (raw)
In-Reply-To: <87fxi4ut2p.fsf@krank.kagedal.org> ("David Kågedal"'s message of "Tue\, 24 Feb 2009 09\:39\:42 +0100")
David Kågedal <davidk@lysator•liu.se> writes:
> David Kågedal <davidk@lysator•liu.se> writes:
>
>> Otherwise it will pick up e.g. lots of irrelevant stuff from
>> refs/bisect, refs/stash or refs/patches (for StGit users).
>>
>> Signed-off-by: David Kågedal <davidk@lysator•liu.se>
>> ---
>> contrib/emacs/git.el | 5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
>> index feb229c..125e684 100644
>> --- a/contrib/emacs/git.el
>> +++ b/contrib/emacs/git.el
>> @@ -1388,7 +1388,10 @@ With a prefix arg, diff the marked files instead."
>> (defun git-read-commit-name (prompt &optional default)
>> "Ask for a commit name, with completion for local branch, remote branch and tag."
>> (completing-read prompt
>> - (list* "HEAD" "ORIG_HEAD" "FETCH_HEAD" (mapcar #'car (git-for-each-ref)))
>> + (list* "HEAD" "ORIG_HEAD" "FETCH_HEAD"
>
> Sorry, I didn't check this properly. I thought I was fixing inside the
> git-checkout function, but this is git-read-commit-name which is used
> in more than one place.
>
> But for git-checkout, I would like to see a much shorter list of named
> commits, namely those that can be called "branches".
... which means that I would like git-read-commit-name to actually
work as its documentation string says it does: "Ask for a commit name,
with completion for local branch, remote branch and tag."
--
David Kågedal
next prev parent reply other threads:[~2009-02-24 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 8:32 [PATCH] git.el: Only show completions from refs/heads, refs/remotes and refs/tags David Kågedal
2009-02-24 8:39 ` David Kågedal
2009-02-24 8:42 ` David Kågedal [this message]
2009-02-24 14:50 ` Alexandre Julliard
2009-02-24 15:40 ` David Kågedal
2009-02-24 15:47 ` Alexandre Julliard
2009-02-24 15:57 ` David Kågedal
2009-02-24 16:06 ` Alexandre Julliard
2009-02-24 20:39 ` [PATCH] git.el: Only show completions from refs/heads David Kågedal
2009-03-01 16:56 ` Alexandre Julliard
2009-03-02 7:45 ` David Kågedal
2009-03-03 14:48 ` Alexandre Julliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d4d8usyd.fsf@krank.kagedal.org \
--to=davidk@lysator$(echo .)liu.se \
--cc=git@vger$(echo .)kernel.org \
--cc=julliard@winehq$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox