Subject: Re: [PATCH v2 0/6] add missing __attribute__((format))

From: Ævar Arnfjörð Bjarmason <[email-masked]>
Date: Wed, 14 Jul 2021 01:05:47 +0200

On Tue, Jul 13 2021, Junio C Hamano wrote:

> Ævar Arnfjörð Bjarmason  <[email-masked]> writes:
> [...]
>>     - ## advice.h ##
>>     -@@ advice.h: int advice_enabled(enum advice_type type);
>>     - /**
>>     -  * Checks the visibility of the advice before printing.
>>     -  */
>>     -+__attribute__((format (printf, 2, 3)))
>>     - void advise_if_enabled(enum advice_type type, const char *advice, ...);
>
> This has become a separate one, because...?
>
> OK, the addition to advise_if_enabled() reveals an existing iffy
> caller, so you chose to fix it and to annotate the function at the
> same time in a single commit at step [5/6].  Makes sense.

Right, it's the only case that revealed an in-codebase warning, so I
thought it made sense to split that up from the mechanical addition of
__attribute__ elsewhere.