Subject: Re: [PATCH v3 25/34] t/perf: avoid copying builtin fsmonitor files into test repo

From: Ævar Arnfjörð Bjarmason <[email-masked]>
Date: Fri, 02 Jul 2021 01:11:26 +0200

On Thu, Jul 01 2021, Jeff Hostetler via GitGitGadget wrote:

> From: Jeff Hostetler <[email-masked]>
>
> Do not try to copy a fsmonitor--daemon socket from the current
> development directory into the test trash directory.

Okey, the */fsmonitor--daemon* rule covers that...

> When we run the perf suite without an explicit source repo set,
> we copy of the current $GIT_DIR into the test trash directory.
> Unix domain sockets cannot be copied in that manner, so the test
> setup fails.
>
> Additionally, omit any other fsmonitor--daemon temp files inside
> the $GIT_DIR directory.

So is the "any other" also matched by that rule? Not knowing the files
part of this is just phrasing, would be less confusing (if that's true,
and you didn't just forget to add a match for them) as:

    The */fsmonitor--daemon* glob will also match temporary files the
    daemon creates, but that's OK. We'd like to ignore these too.