From: David Kastrup <dak@gnu•org>
To: git@vger•kernel.org
Subject: Re: [PATCH 1/2] builtin/blame.c: struct blame_entry does not need a prev link
Date: Wed, 22 Jan 2014 00:02:45 +0100 [thread overview]
Message-ID: <87eh41os4q.fsf@fencepost.gnu.org> (raw)
In-Reply-To: xmqqlhy9t2z1.fsf@gitster.dls.corp.google.com
Junio C Hamano <gitster@pobox•com> writes:
> David Kastrup <dak@gnu•org> writes:
>
>> ---
>
> Thanks. At some point during its development I must have thought
> that having it as a dual-linked list may make it easier when we have
> to split a block into pieces, but it seems that split_overlap() does
> not need to look at this information.
>
> Needs sign-off.
Well, as I said: it's quite possible that the double-linking might be
useful for some particular hypothetical rewrite of the code. It isn't
for the current code, and it's not useful for my own rewrite.
Will be posting a signed-off version presently.
--
David Kastrup
next prev parent reply other threads:[~2014-01-21 23:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-19 18:57 [PATCH 0/2] Two janitorial patches for builtin/blame.c David Kastrup
2014-01-19 18:57 ` [PATCH 1/2] builtin/blame.c: struct blame_entry does not need a prev link David Kastrup
2014-01-21 21:54 ` Junio C Hamano
2014-01-21 23:02 ` David Kastrup [this message]
2014-01-19 18:57 ` [PATCH 2/2] Eliminate same_suspect function in builtin/blame.c David Kastrup
2014-01-21 16:22 ` [PATCH 0/2] Two janitorial patches for builtin/blame.c David Kastrup
2014-01-21 16:55 ` Jonathan Nieder
2014-01-21 17:40 ` David Kastrup
2014-01-21 17:44 ` Jonathan Nieder
2014-01-21 17:58 ` David Kastrup
2014-01-21 19:15 ` Jonathan Nieder
2014-01-21 19:56 ` David Kastrup
2014-01-21 20:01 ` Jonathan Nieder
2014-01-21 21:30 ` David Kastrup
2014-01-21 20:20 ` Junio C Hamano
2014-01-21 22:56 ` David Kastrup
2014-01-21 19:53 ` Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2014-01-22 0:20 [PATCH 0/2] Two mostly " David Kastrup
2014-01-22 0:20 ` [PATCH 1/2] builtin/blame.c: struct blame_entry does not need a prev link David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh41os4q.fsf@fencepost.gnu.org \
--to=dak@gnu$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox