public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Thomas Rast <tr@thomasrast•ch>
To: Nicolas Cornu <ncornu@aldebaran-robotics•com>
Cc: git@vger•kernel.org, gitster@pobox•com
Subject: Re: [PATCH] Add a scrollbar for commit history in gitk
Date: Wed, 30 Oct 2013 07:35:01 +0100	[thread overview]
Message-ID: <87fvrjgtbe.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <CAMXp-VN=CMRdXwJ3+LRZegm-bwiDmJd66-YnZb65BNpqyHQCLA@mail.gmail.com> (Nicolas Cornu's message of "Tue, 29 Oct 2013 14:53:23 +0100")

Hi Nicolas,

Thanks for your patch.

You should Cc Paul Mackerras <paulus@samba•org> on gitk patches.

Nicolas Cornu <ncornu@aldebaran-robotics•com> writes:

> From b3570290bd761a1bf952ea491fa62b123231fe61 Mon Sep 17 00:00:00 2001
> From: Nicolas Cornu <ncornu@aldebaran-robotics•com>
> Date: Tue, 29 Oct 2013 14:51:29 +0100
> Subject: [PATCH] Add a scrollbar for commit history in gitk

You don't need these headers, they'll be taken from the email.  You only
need to put them if they don't agree (e.g., you are sending someone
else's patch).

Can you describe your patch in more detail, and spin a commit message
from it?  My first reaction to "Add a scrollbar for commit history in
gitk" is "there *is* a scrollbar".

The code hints that the scrollbar may be horizontal?  Is this worth the
vertical space it spends?  Should it be optional?  The commit message
should address these questions.

> ---
>  gitk-git/gitk | 8 +++++++-

You should eventually base your patch against the gitk.git repository,
which does not have the toplevel gitk-git/ prefix.

>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index d6f5e07..e517253 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -2124,11 +2124,17 @@ proc makewindow {} {
>      # create three canvases
>      set cscroll .tf.histframe.csb
>      set canv .tf.histframe.pwclist.canv
> +    set cscrollhl .tf.histframe.pwclist.canv.csb
>      canvas $canv \
>      -selectbackground $selectbgcolor \
>      -background $bgcolor -bd 0 \
> -    -yscrollincr $linespc -yscrollcommand "scrollcanv $cscroll"
> +    -yscrollincr $linespc -yscrollcommand "scrollcanv $cscroll" \
> +    -xscrollcommand "scrollcanv $cscrollhl"
>      .tf.histframe.pwclist add $canv
> +    ${NS}::scrollbar $cscrollhl -command {$canv xview} -orient horizontal
> +    if {!$use_ttk} {$cscrollhl configure -highlightthickness 0}
> +    pack $cscrollhl -fill x -side bottom
> +
>      set canv2 .tf.histframe.pwclist.canv2
>      canvas $canv2 \
>      -selectbackground $selectbgcolor \

-- 
Thomas Rast
tr@thomasrast•ch

     prev parent reply	other threads:[~2013-10-30  6:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 13:53 [PATCH] Add a scrollbar for commit history in gitk Nicolas Cornu
2013-10-30  6:35 ` Thomas Rast [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fvrjgtbe.fsf@linux-k42r.v.cablecom.net \
    --to=tr@thomasrast$(echo .)ch \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=ncornu@aldebaran-robotics$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox