Subject: Re: [PATCH 02/16] sha1_file: refactor into `find_pack_object_pos`

From: Thomas Rast <[email-masked]>
Date: Tue, 25 Jun 2013 15:59:28 +0200

Vicent Marti <[email-masked]> writes:

>  	if (use_lookup) {
> -		int pos = sha1_entry_pos(index, stride, 0,
> -					 lo, hi, p->num_objects, sha1);
> -		if (pos < 0)
> -			return 0;
> -		return nth_packed_object_offset(p, pos);
> +		return sha1_entry_pos(index, stride, 0, lo, hi, p->num_objects, sha1);
>  	}

Our house style prefers not having the braces in a single-line conditional.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch