From: Thomas Rast <trast@inf•ethz.ch>
To: John Keeping <john@keeping•me.uk>
Cc: <git@vger•kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx•de>,
Jeff King <peff@peff•net>
Subject: Re: [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY
Date: Mon, 29 Apr 2013 20:00:27 +0200 [thread overview]
Message-ID: <87fvy9dxok.fsf@hexa.v.cablecom.net> (raw)
In-Reply-To: <47c9ba4200a22e865040208628357d9bc4bcf3f4.1367002553.git.john@keeping.me.uk> (John Keeping's message of "Fri, 26 Apr 2013 19:55:53 +0100")
John Keeping <john@keeping•me.uk> writes:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index ca6bdef..70ad085 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -54,8 +54,8 @@ done,*)
> # do not redirect again
> ;;
> *' --tee '*|*' --va'*)
> - mkdir -p test-results
> - BASE=test-results/$(basename "$0" .sh)
> + mkdir -p "$(TEST_OUTPUT_DIRECTORY)/test-results"
> + BASE="$(TEST_OUTPUT_DIRECTORY)/test-results/$(basename "$0" .sh)"
> (GIT_TEST_TEE_STARTED=done ${SHELL_PATH} "$0" "$@" 2>&1;
> echo $? > $BASE.exit) | tee $BASE.out
> test "$(cat $BASE.exit)" = 0
Hmm, I initially was too lazy to review this change, and now it's biting
me. The above is Makefile-quoted, which to the shell reads like a
command substitution.
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-04-29 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 18:55 [PATCH 1/2] t/Makefile: fix result handling with TEST_OUTPUT_DIRECTORY John Keeping
2013-04-26 18:55 ` [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY John Keeping
2013-04-29 18:00 ` Thomas Rast [this message]
2013-04-29 18:16 ` [PATCH 2/2 v2] " John Keeping
2013-04-29 18:17 ` [PATCH 2/2] " Junio C Hamano
2013-04-29 18:19 ` John Keeping
2013-04-29 18:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvy9dxok.fsf@hexa.v.cablecom.net \
--to=trast@inf$(echo .)ethz.ch \
--cc=git@vger$(echo .)kernel.org \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=john@keeping$(echo .)me.uk \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox