From: Eric Lesh <eclesh@ucla•edu>
To: Josef Sipek <jsipek@fsl•cs.sunysb.edu>
Cc: jsipek@cs•sunysb.edu, git@vger•kernel.org
Subject: Re: [GUILT PATCH 3/4] guilt-select: Select guards to apply when pushing patches
Date: Mon, 30 Jul 2007 00:02:26 -0700 [thread overview]
Message-ID: <87fy36cr25.fsf@hubert.paunchy.net> (raw)
In-Reply-To: <20070730041231.GE22017@filer.fsl.cs.sunysb.edu> (Josef Sipek's message of "Mon\, 30 Jul 2007 00\:12\:31 -0400")
Josef Sipek <jsipek@fsl•cs.sunysb.edu> writes:
[...]
>> +if [ $# == 0 ]; then
>> + if [ -s "$guards_file" ]; then
>> + cat "$guards_file"
>
> Later on, for the -s option processing, you sort (presumably to have uniq do
> the right thing), should we sort here too to be consitent?
>
The $guards_file isn't really meant to be handed edited, and
guilt-select itself sorts before it stores them in the guards file. I could
sort it again on printing, but don't think it's necessary.
>> +
>> +case $1 in
>> + -n|--none)
>> + rm -f "$guards_file"
>> + touch "$guards_file"
>
> Since guilt-init doesn't create the guards file, I'm thinking that this
> should be just a rm -f ...
Should guilt-init create it? I added $guards_file to guilt(7), so not
seeing it might freak Documentation-conscious readers out?
Eric
next prev parent reply other threads:[~2007-07-30 7:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 7:50 [GUILT PATCH 0/4] Add guards to guilt Eric Lesh
2007-07-29 7:50 ` [GUILT PATCH 1/4] get_series: Remove comments from end of series lines Eric Lesh
2007-07-30 3:54 ` Josef Sipek
2007-07-30 5:15 ` Eric Lesh
2007-07-30 5:26 ` Josef Sipek
2007-07-30 7:07 ` Eric Lesh
2007-07-29 7:50 ` [GUILT PATCH 2/4] guilt-guard: Assign guards to patches in series Eric Lesh
2007-07-30 4:06 ` Josef Sipek
2007-07-30 6:41 ` Eric Lesh
2007-07-30 19:28 ` Josef Sipek
2007-07-29 7:50 ` [GUILT PATCH 3/4] guilt-select: Select guards to apply when pushing patches Eric Lesh
2007-07-30 4:12 ` Josef Sipek
2007-07-30 7:02 ` Eric Lesh [this message]
2007-07-30 19:34 ` Josef Sipek
2007-07-29 7:50 ` [GUILT PATCH 4/4] Use guards information and functions Eric Lesh
2007-07-30 4:15 ` Josef Sipek
2007-07-30 7:06 ` Eric Lesh
2007-07-30 3:54 ` [GUILT PATCH 0/4] Add guards to guilt Josef Sipek
2007-07-30 8:32 ` Eric Lesh
2007-07-30 19:20 ` Josef Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fy36cr25.fsf@hubert.paunchy.net \
--to=eclesh@ucla$(echo .)edu \
--cc=git@vger$(echo .)kernel.org \
--cc=jsipek@cs$(echo .)sunysb.edu \
--cc=jsipek@fsl$(echo .)cs.sunysb.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox