From: Toon Claes <toon@iotcl•com>
To: Patrick Steinhardt <ps@pks•im>, git@vger•kernel.org
Cc: Ramsay Jones <ramsay@ramsayjones•plus.com>,
irecca.kun@gmail•com, Eli Schwartz <eschwartz@gentoo•org>,
Jeff King <peff@peff•net>, Junio C Hamano <gitster@pobox•com>,
Justin Tobler <jltobler@gmail•com>
Subject: Re: [PATCH v3 3/8] meson: improve summary of auto-detected features
Date: Thu, 10 Jul 2025 17:25:49 +0200 [thread overview]
Message-ID: <87h5zkcbk2.fsf@iotcl.com> (raw)
In-Reply-To: <20250709-b4-pks-meson-cleanups-v3-3-29ab15b9ab85@pks.im>
Patrick Steinhardt <ps@pks•im> writes:
> The summary of auto-detected features prints a boolean for every option
> to tell the user whether or not the feature has been auto-enabled or
> not. This summary can be improved though, as in some cases this boolean
> is derived from a dependency. So if we pass in the dependency directly,
> then Meson knows to both print a boolean and, if the dependency was
> found, it also prints a version number.
>
> Adapt the code accordingly and enable `bool_yn` so that actual booleans
> are formatted similarly to dependencies. Before this change:
>
> Auto-detected features
> benchmarks : true
> curl : true
> expat : true
> gettext : true
> gitweb : true
> iconv : true
> pcre2 : true
> perl : true
> python : true
>
> And after this change, we now see the version numbers as expected:
>
> Auto-detected features
> benchmarks : YES
> curl : YES 8.14.1
> expat : YES 2.7.1
> gettext : YES
> gitweb : YES
> iconv : YES
> pcre2 : YES 10.44
> perl : YES
> python : YES
>
> Note that this change also enables colorization of the boolean options,
> green for "YES" and red for "NO".
Nice, I'm really liking this change.
I've also reviewed the rest of the patches, and all looks good to me.
--
Cheers,
Toon
next prev parent reply other threads:[~2025-07-10 15:26 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 9:28 [PATCH 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-08 19:38 ` Justin Tobler
2025-07-09 6:16 ` Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-08 19:56 ` Justin Tobler
2025-07-03 9:28 ` [PATCH 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-03 16:39 ` Ramsay Jones
2025-07-08 8:44 ` Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-03 9:28 ` [PATCH 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-08 0:16 ` Junio C Hamano
2025-07-08 1:12 ` Jeff King
2025-07-08 1:39 ` Jeff King
2025-07-08 4:39 ` Junio C Hamano
2025-07-08 7:16 ` Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-08 20:44 ` Justin Tobler
2025-07-08 7:57 ` [PATCH v2 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-08 7:57 ` [PATCH v2 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-09 6:23 ` [PATCH v3 0/8] A handful of Meson cleanups and improvements Patrick Steinhardt
2025-07-09 6:23 ` [PATCH v3 1/8] meson: stop discovering native version of Python Patrick Steinhardt
2025-07-09 15:09 ` Junio C Hamano
2025-07-09 21:36 ` Justin Tobler
2025-07-09 22:22 ` Eli Schwartz
2025-07-09 22:40 ` Junio C Hamano
2025-07-09 6:23 ` [PATCH v3 2/8] meson: stop printing 'https' option twice in our summaries Patrick Steinhardt
2025-07-09 15:17 ` Junio C Hamano
2025-07-09 6:23 ` [PATCH v3 3/8] meson: improve summary of auto-detected features Patrick Steinhardt
2025-07-10 15:25 ` Toon Claes [this message]
2025-07-10 16:24 ` Junio C Hamano
2025-07-09 6:23 ` [PATCH v3 4/8] meson: clean up unnecessary variables Patrick Steinhardt
2025-07-09 6:23 ` [PATCH v3 5/8] meson: fix lookup of shell on MINGW64 Patrick Steinhardt
2025-07-09 6:23 ` [PATCH v3 6/8] meson: fix GIT_EXEC_PATH with overridden -Dlibexecdir= Patrick Steinhardt
2025-07-09 6:23 ` [PATCH v3 7/8] meson: update subproject wrappers Patrick Steinhardt
2025-07-09 6:23 ` [PATCH v3 8/8] ci: use Meson's new `--slice` option Patrick Steinhardt
2025-07-09 21:37 ` [PATCH v3 0/8] A handful of Meson cleanups and improvements Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h5zkcbk2.fsf@iotcl.com \
--to=toon@iotcl$(echo .)com \
--cc=eschwartz@gentoo$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=irecca.kun@gmail$(echo .)com \
--cc=jltobler@gmail$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
--cc=ramsay@ramsayjones$(echo .)plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox