From: Toon Claes <toon@iotcl•com>
To: Junio C Hamano <gitster@pobox•com>, Patrick Steinhardt <ps@pks•im>
Cc: Toon Claes <toon@iotcl•com>, git@vger•kernel.org
Subject: Re: [PATCH] bundle-uri: plug leak in unbundle_from_file()
Date: Tue, 01 Oct 2024 20:58:41 +0200 [thread overview]
Message-ID: <87ikubsl9a.fsf@iotcl.com> (raw)
In-Reply-To: <xmqqle0jmfpf.fsf@gitster.g>
Junio C Hamano <gitster@pobox•com> writes:
> Thanks for reviewing carefully.
>
> Both of two callers of unbundle_from_file() are used as the
> condition of an if() statement, so unbundle() that signals an error
> with -1 wouldn't be a problem, I would think.
Hi Junio,
I've noticed this patch wasn't picked up yet. Is there anything you want
me to change and have me sent another version, or is it good to go in?
--
Toon
next prev parent reply other threads:[~2024-10-01 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 8:30 [PATCH] bundle-uri: plug leak in unbundle_from_file() Toon Claes
2024-08-26 9:51 ` Patrick Steinhardt
2024-08-26 16:06 ` Junio C Hamano
2024-10-01 18:58 ` Toon Claes [this message]
2024-10-01 19:29 ` Junio C Hamano
2024-10-10 9:15 ` Toon Claes
2024-10-10 9:12 ` [PATCH v2] " Toon Claes
2024-10-10 12:55 ` Patrick Steinhardt
2024-10-10 18:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikubsl9a.fsf@iotcl.com \
--to=toon@iotcl$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox