From: Thomas Rast <trast@inf•ethz.ch>
To: Felipe Contreras <felipe.contreras@gmail•com>
Cc: <git@vger•kernel.org>, Junio C Hamano <gitster@pobox•com>,
John Keeping <john@keeping•me.uk>,
Sverre Rabbelier <srabbelier@gmail•com>, Max Horn <max@quendi•de>,
Jonathan Nieder <jrnieder@gmail•com>,
Florian Achleitner <florian.achleitner.2.6.31@gmail•com>
Subject: Re: [PATCH 1/6] transport-helper: clarify *:* refspec
Date: Thu, 18 Apr 2013 09:28:05 +0200 [thread overview]
Message-ID: <87li8gxpq2.fsf@linux-k42r.v.cablecom.net> (raw)
In-Reply-To: <1366243524-18202-2-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Wed, 17 Apr 2013 19:05:19 -0500")
Felipe Contreras <felipe.contreras@gmail•com> writes:
> The *:* refspec doesn't work, and never has, clarify the code and
> documentation to reflect that. This in effect reverts commit 9e7673e
> (gitremote-helpers(1): clarify refspec behaviour).
[...]
> -test_expect_success 'pulling with straight refspec' '
> - (cd local2 &&
> - GIT_REMOTE_TESTGIT_REFSPEC="*:*" git pull) &&
> - compare_refs local2 HEAD server HEAD
> -'
> -
> -test_expect_failure 'pushing with straight refspec' '
> - test_when_finished "(cd local2 && git reset --hard origin)" &&
> - (cd local2 &&
> - echo content >>file &&
> - git commit -a -m eleven &&
> - GIT_REMOTE_TESTGIT_REFSPEC="*:*" git push) &&
> - compare_refs local2 HEAD server HEAD
> -'
So what's wrong with the tests? Do they fail to test what they claim
(how?), test something that wasn't reasonable to begin with, or
something entirely different?
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2013-04-18 7:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 0:05 [PATCH 0/6] transport-helper: some clarifications and a fix Felipe Contreras
2013-04-18 0:05 ` [PATCH 1/6] transport-helper: clarify *:* refspec Felipe Contreras
2013-04-18 7:28 ` Thomas Rast [this message]
2013-04-18 8:18 ` Felipe Contreras
2013-04-18 12:39 ` Thomas Rast
2013-04-18 13:06 ` Felipe Contreras
2013-04-18 0:05 ` [PATCH 2/6] transport-helper: update refspec documentation Felipe Contreras
2013-04-18 0:05 ` [PATCH 3/6] transport-helper: clarify pushing without refspecs Felipe Contreras
2013-04-18 0:14 ` Sverre Rabbelier
2013-04-18 18:56 ` Stefano Lattarini
2013-04-18 0:05 ` [PATCH 4/6] transport-helper: warn when refspec is not used Felipe Contreras
2013-04-18 0:05 ` [PATCH 5/6] transport-helper: trivial code shuffle Felipe Contreras
2013-04-18 0:05 ` [PATCH 6/6] transport-helper: update remote helper namespace Felipe Contreras
2013-04-18 4:14 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li8gxpq2.fsf@linux-k42r.v.cablecom.net \
--to=trast@inf$(echo .)ethz.ch \
--cc=felipe.contreras@gmail$(echo .)com \
--cc=florian.achleitner.2.6.31@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=john@keeping$(echo .)me.uk \
--cc=jrnieder@gmail$(echo .)com \
--cc=max@quendi$(echo .)de \
--cc=srabbelier@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox