Subject: Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set

From: Thomas Rast <[email-masked]>
Date: Tue, 28 Feb 2012 15:34:13 +0100

Nelson Benitez Leon <[email-masked]> writes:

> On 02/28/2012 01:19 PM, Thomas Rast wrote:
>> 
>> * Why is this needed?  Does git's use of libcurl ignore http_proxy?  [1]
>>   seems to indicate that libcurl respects <protocol>_proxy
>>   automatically.
>
> It could not be needed, because, as you noted, curl already reads it, but then we will
> loose the feature on patch [3/3] because if $http_proxy has username but no password
> curl will not ask you for the password.. instead if we read it we could detect that,
> and ask for the password. 

Ok.  An explanation along these lines should definitely go into the
commit message!

-- 
Thomas Rast
trast@{inf,student}.ethz.ch