Subject: Re: [PATCH v2 04/30] subtree: t7900: use consistent formatting

From: Luke Shumaker <[email-masked]>
Date: Mon, 26 Apr 2021 13:57:48 -0600

On Mon, 26 Apr 2021 11:44:59 -0600,
Luke Shumaker wrote:
> @@ -50,15 +46,17 @@ undo()
>  # The original set of commits changed only one file each.
>  # A multi-file change would imply that we pruned commits
>  # too aggressively.
> -join_commits()
> -{
> +join_commits () {
>  	commit=
>  	all=
>  	while read x y; do
> -		if [ -z "$x" ]; then
> +		if test -z "$x"
> +		then
>  			continue
> -		elif [ "$x" = "commit:" ]; then
> -			if [ -n "$commit" ]; then
> +		elif test "$x" = "commit:"
> +		then
> +			if test -n "$commit"
> +			then
>  				echo "$commit $all"
>  				all=
>  			fi

Whoops, I should have changed those 1-line `while ...; do`'s, in
addition to the 1-line `if ...; then`'s.

-- 
Happy hacking,
~ Luke Shumaker