Subject: Re: [PATCH] send-email: add test for Linux's get_maintainer.pl

From: Alex Bennée <[email-masked]>
Date: Fri, 05 Jan 2018 11:15:41 +0000

Matthieu Moy <[email-masked]> writes:

> From: Alex Bennée <[email-masked]>
>
> We had a regression that broke Linux's get_maintainer.pl. Using
> Mail::Address to parse email addresses fixed it, but let's protect
> against future regressions.
>
> Patch-edited-by: Matthieu Moy <[email-masked]>
> Signed-off-by: Alex Bennée <[email-masked]>
> Signed-off-by: Matthieu Moy <[email-masked]>
> ---
>  t/t9001-send-email.sh | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 4d261c2..f126177 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -172,6 +172,28 @@ test_expect_success $PREREQ 'cc trailer with various syntax' '
>  	test_cmp expected-cc commandline1
>  '
>
> +test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc trailer' "
> +	cat >expected-cc-script.sh <<-EOF &&
> +	#!/bin/sh
> +	echo 'One Person <[email-masked]> (supporter:THIS (FOO/bar))'
> +	echo 'Two Person <[email-masked]> (maintainer:THIS THING)'
> +	echo 'Third List <[email-masked]> (moderated list:THIS THING (FOO/bar))'
> +	echo '<[email-masked]> (moderated list:FOR THING)'
> +	echo [email-masked] (open list:FOR THING (FOO/bar))'
> +	echo [email-masked] (open list)'
> +	EOF
> +	chmod +x expected-cc-script.sh
> +"
> +
> +test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' '
> +	test_commit cc-trailer-getmaint &&
> +	clean_fake_sendmail &&
> +	git send-email -1 --to=[email-masked] \
> +		--cc-cmd="./expected-cc-script.sh" \
> +		--smtp-server="$(pwd)/fake.sendmail" &&
> +	test_cmp expected-cc commandline1
> +'
> +
>  test_expect_success $PREREQ 'setup expect' "
>  cat >expected-show-all-headers <<\EOF
>  0001-Second.patch

I think you need to apply Eric's suggestions from:

  From: Eric Sunshine <[email-masked]>
  Date: Sat, 18 Nov 2017 21:54:46 -0500
  Message-ID: <[email-masked]>

--
Alex Bennée