From: Sergei Organov <osv@javad•com>
To: mmogilvi_git@miniinfo•net
Cc: git@vger•kernel.org, gitster@pobox•com
Subject: Re: [PATCH] cvsserver: make the output of 'update' more compatible with cvs.
Date: Mon, 07 Dec 2009 11:27:57 +0300 [thread overview]
Message-ID: <87ocmbdw8i.fsf@osv.gnss.ru> (raw)
In-Reply-To: <20091205234831.GA925@comcast.net> (mmogilvi git's message of "Sat\, 5 Dec 2009 16\:48\:31 -0700")
mmogilvi_git@miniinfo•net writes:
> On Thu, Dec 03, 2009 at 11:12:47PM +0300, Sergei Organov wrote:
>>
>> + my $last_dirname = "///";
>> +
>> # foreach file specified on the command line ...
>> foreach my $filename ( @{$state->{args}} )
>> {
>> $filename = filecleanup($filename);
>> + my $cur_dirname = dirname($filename);
>> + if ( $cur_dirname ne $last_dirname )
>> + {
>> + $last_dirname = $cur_dirname;
>> + if ( $cur_dirname eq "" )
>> + {
>> + $cur_dirname = ".";
>> + }
>> + print "E cvs update: Updating $cur_dirname\n";
>> + }
>>
>> $log->debug("Processing file $filename");
>
> This should probably be conditional on the absense of the
> global "cvs -q update" and "cvs -Q update" options, in case
> other CVS clients depend on quiet operation when they specify
> those options.
Good catch, thanks! I'll redo the patch.
-- Sergei.
next prev parent reply other threads:[~2009-12-07 8:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 20:12 [PATCH] cvsserver: make the output of 'update' more compatible with cvs Sergei Organov
2009-12-05 23:48 ` mmogilvi_git
2009-12-07 8:27 ` Sergei Organov [this message]
2009-12-07 11:11 ` [PATCH v2] " Sergei Organov
2009-12-30 13:41 ` Nanako Shiraishi
2009-12-31 6:47 ` Junio C Hamano
2009-12-31 15:20 ` Martin Langhoff
2009-12-31 20:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ocmbdw8i.fsf@osv.gnss.ru \
--to=osv@javad$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mmogilvi_git@miniinfo$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox