From: "Strawbridge, Michael" <Michael.Strawbridge@amd•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "git@vger•kernel.org" <git@vger•kernel.org>,
"Tuikov, Luben" <Luben.Tuikov@amd•com>
Subject: Re: [PATCH v7 2/2] send-email: expose header information to git-send-email's sendemail-validate hook
Date: Tue, 17 Jan 2023 20:57:11 +0000 [thread overview]
Message-ID: <87pmbc3mmx.fsf@amd.com> (raw)
In-Reply-To: <xmqqedrt9mmt.fsf@gitster.g>
Junio C Hamano <gitster@pobox•com> writes:
> "Strawbridge, Michael" <Michael.Strawbridge@amd•com> writes:
>
>> +This hook is invoked by linkgit:git-send-email[1].
>> +
>> +It takes these command line arguments. They are,
>> +1. the name of the file which holds the contents of the email to be sent.
>> +2. The name of the file which holds the SMTP envelope and headers of the email.
>
> The previous iteration said SMTP headers, but now this talks about
> envelope. I however did not think we have direct access to any
> envelope information [*] (i.e. such a feature is necessary if we
> want to send to one set of recipients by specifying their addresses
> in the envelope, while recording different set of recipients to the
> e-mail headers' To: and Cc: list)?
>
> Side note. We can specify different sender and it gets
> passed as a command line argument "-f $sender" to the
> sendmail program, which is used in "MAIL FROM" SMTP
> envelope. But I do not think we muck with the list of
> recipients that appear in the header when we formulate "RCPT
> TO". And I do not see where you give "MAIL FROM" value in
> the input to the hook in the patch.
>
> If we say "we will give your hook information in the envelope and
> headers" to those who know the distinction between the two, they
> will inevitably say "that is great. Now how do I tell which in file
> $2 are in the envelope and which are in the header, when some of
> them are different?"
>
> We just hand the message plus the header, and let $sendmail_cmd come
> up with the envelope info using what is in the header, no? I am not
> sure we want to mention envelope as that would give readers a false
> impression that we may treat it separately from the headers.
>
> Thanks.
That's fair. I will remove the mention of envelope.
prev parent reply other threads:[~2023-01-17 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 14:27 [PATCH v7 0/2] send-email: expose header information to git-send-email's sendemail-validate hook Strawbridge, Michael
2023-01-17 14:27 ` [PATCH v7 1/2] send-email: refactor header generation functions Strawbridge, Michael
2023-01-17 14:27 ` [PATCH v7 2/2] send-email: expose header information to git-send-email's sendemail-validate hook Strawbridge, Michael
2023-01-17 16:00 ` Junio C Hamano
2023-01-17 20:57 ` Strawbridge, Michael [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmbc3mmx.fsf@amd.com \
--to=michael.strawbridge@amd$(echo .)com \
--cc=Luben.Tuikov@amd$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox