Subject: Re: [PATCH 4/6] tests: use "test_might_fail ok=sigpipe grep" when appropriate

From: Ævar Arnfjörð Bjarmason <[email-masked]>
Date: Fri, 15 Jan 2021 10:14:40 +0100

On Fri, Jan 15 2021, Ævar Arnfjörð Bjarmason wrote:

>  test_expect_success 'cherry picks did not become git merge commits' '
>  	bad_cherries=$(git rev-list --parents --all --grep=Cherry |
> -		grep " .* " | cut -f1 -d" ") &&
> +		test_might_fail ok=sigpipe grep grep " .* " | cut -f1 -d" ") &&
> [...]
> -		grep " .* " | cut -f1 -d" ") &&
> +		test_might_fail ok=sigpipe grep grep " .* " | cut -f1 -d" ") &&

So, "grep grep" is an obvious typo there. Oops. The test still passes
because it's fragile to begin with, we're just checking that we get no
output, so "grep this string is not here" would also pass.