From: Pat Thoyts <patthoyts@users•sourceforge.net>
To: "René Scharfe" <l.s.r@web•de>
Cc: Olaf Hering <olaf@aepfle•de>, git@vger•kernel.org
Subject: Re: [PATCH] git-gui: sort entries in tclIndex
Date: Fri, 01 May 2015 15:57:38 +0100 [thread overview]
Message-ID: <87sibgpcpp.fsf@red.patthoyts.tk> (raw)
In-Reply-To: <553BC05F.1070702@web.de> ("René Scharfe"'s message of "Sat, 25 Apr 2015 18:27:11 +0200")
René Scharfe <l.s.r@web•de> writes:
>Looping in Pat (git-gui maintainer).
>
>Am 15.04.2015 um 09:22 schrieb Olaf Hering:
>> Ping?
>>
>> On Tue, Feb 10, Olaf Hering wrote:
>>
>>> Ping?
>>>
>>> On Mon, Jan 26, Olaf Hering wrote:
>>>
>>>> ALL_LIBFILES uses wildcard, which provides the result in directory
>>>> order. This order depends on the underlying filesystem on the
>>>> buildhost. To get reproducible builds it is required to sort such list
>>>> before using them.
>>>>
>>>> Signed-off-by: Olaf Hering <olaf@aepfle•de>
>>>> ---
>>>> git-gui/Makefile | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/git-gui/Makefile b/git-gui/Makefile
>>>> index cde8b2e..7564a18 100644
>>>> --- a/git-gui/Makefile
>>>> +++ b/git-gui/Makefile
>>>> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
>>>> rm -f $@ ; \
>>>> echo '# Autogenerated by git-gui Makefile' >$@ && \
>>>> echo >>$@ && \
>>>> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
>>>> echo >>$@ ; \
>>>> fi
>>>>
>
Applied. Thank you.
--
Pat Thoyts http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD
next prev parent reply other threads:[~2015-05-01 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 17:07 [PATCH] git-gui: sort entries in tclIndex Olaf Hering
2015-02-10 15:18 ` Olaf Hering
2015-04-15 7:22 ` Olaf Hering
2015-04-25 16:27 ` René Scharfe
2015-05-01 14:57 ` Pat Thoyts [this message]
2015-10-05 7:43 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sibgpcpp.fsf@red.patthoyts.tk \
--to=patthoyts@users$(echo .)sourceforge.net \
--cc=git@vger$(echo .)kernel.org \
--cc=l.s.r@web$(echo .)de \
--cc=olaf@aepfle$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox