public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Toon Claes <toon@iotcl•com>
To: Jeff King <peff@peff•net>
Cc: Junio C Hamano <gitster@pobox•com>,
	Todd Zullinger <tmz@pobox•com>,
	Elia Pinto <gitter.spiros@gmail•com>,
	Usman Akinyemi <usmanakinyemi202@gmail•com>,
	Andreas Schwab <schwab@linux-m68k•org>,
	Christian Couder <christian.couder@gmail•com>,
	git@vger•kernel.org
Subject: Re: [PATCH 2/1] test-lib: move malloc-debug setup after $PATH setup
Date: Wed, 20 Nov 2024 14:51:21 +0100	[thread overview]
Message-ID: <87ttc2rp2e.fsf@iotcl.com> (raw)
In-Reply-To: <20241114013912.GA1155455@coredump.intra.peff.net>

Jeff King <peff@peff•net> writes:

> Originally, the conditional definition of the setup/teardown functions
> for malloc checking could be run at any time, because they depended only
> on command-line options and the system getconf function.
>
> [...snip...]
>
>  if test -z "$GIT_TEST_CMP"
>  then
>  	if test -n "$GIT_TEST_CMP_USE_COPIED_CONTEXT"
> -- 
> 2.47.0.527.gfb211c7f3b

For what it's worth, I've tested this patch and I wanted to quickly
confirm this works as expected.

-- 
Toon

  reply	other threads:[~2024-11-20 13:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09  6:01 [RFC]: Test Were failing on Fedora Linux Usman Akinyemi
2024-11-09  8:12 ` Christian Couder
2024-11-09  9:32   ` Usman Akinyemi
2024-11-09 14:01     ` Christian Couder
2024-11-09 14:35       ` Andreas Schwab
2024-11-09 15:02         ` Usman Akinyemi
2024-11-09 16:05           ` Todd Zullinger
2024-11-09 19:00             ` Jeff King
2024-11-09 19:12               ` Usman Akinyemi
2024-11-11  3:11               ` Junio C Hamano
2024-11-11  7:01                 ` [PATCH] test-lib: check malloc debug LD_PRELOAD before using Jeff King
2024-11-13 10:19                   ` Toon Claes
2024-11-14  1:27                     ` Jeff King
2024-11-14  1:39                       ` [PATCH 2/1] test-lib: move malloc-debug setup after $PATH setup Jeff King
2024-11-20 13:51                         ` Toon Claes [this message]
2024-11-20 23:26                           ` Junio C Hamano
2024-11-09 19:09             ` [RFC]: Test Were failing on Fedora Linux Usman Akinyemi
2024-11-09 14:59       ` Usman Akinyemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttc2rp2e.fsf@iotcl.com \
    --to=toon@iotcl$(echo .)com \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=gitter.spiros@gmail$(echo .)com \
    --cc=peff@peff$(echo .)net \
    --cc=schwab@linux-m68k$(echo .)org \
    --cc=tmz@pobox$(echo .)com \
    --cc=usmanakinyemi202@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox