Subject: Re: [PATCH] git-add--interactive.perl: Remove two unused variables

From: Thomas Rast <[email-masked]>
Date: Mon, 25 Jun 2012 11:12:14 +0200

Junio C Hamano <[email-masked]> writes:

> "Thomas \"Enki\" Badie" <[email-masked]> writes:
>
>> The patch 8f0bef6 refactors this script and leaves the `$fh' variable
>> unused in `diff_applies' and `patch_update_file'.
[...]
>  (2) the author of the problematic commit should have been Cc'ed
>      (especially when he is still an active participant on the list)
>      to give him a chance to Ack it (I'm adding Thomas for this).

Indeed, my bad.  It's easy to verify from 'git show 8f0bef6' that this
was an oversight in my patch.

Acked-by: Thomas Rast <[email-masked]>

-- 
Thomas Rast
trast@{inf,student}.ethz.ch