Subject: Re: [Wishlist] could git tell which password it is asking when asking a password.

From: Rémi Vanicat <[email-masked]>
Date: Fri, 01 Jul 2011 21:25:59 +0200

Junio C Hamano <[email-masked]> writes:

> Shawn Pearce <[email-masked]> writes:
>
>> On Fri, Jul 1, 2011 at 10:16, Junio C Hamano <[email-masked]> wrote:
>>> Junio C Hamano <[email-masked]> writes:
>>> diff --git a/http.c b/http.c
>>> index b2ae8de..44948a7 100644
>>> --- a/http.c
>>> +++ b/http.c
>>> @@ -209,8 +209,11 @@ static void init_curl_http_auth(CURL *result)
>>>  {
>>>        if (user_name) {
>>>                struct strbuf up = STRBUF_INIT;
>>> -               if (!user_pass)
>>> -                       user_pass = xstrdup(git_getpass("Password: "));
>>> +               if (!user_pass) {
>>> +                       strbuf_addf(&up, "Password for %s: ", user_name);
>>
>> The user_name by itself may not be sufficient. I may also need the URL
>> to correctly answer the question. I don't always use the same password
>> on every website. :-)
>>
>> As a human sure, I know what URL I asked Git to poke for me.
>
> I was wondering about that when I gave that quick patch.  And "as a human"
> may not necessarily apply when you are letting submodule fetch to recurse.

I also believe that having the host name would be useful, both for human
(another example would be git remote update when there are several
remote) and script.  

-- 
Rémi Vanicat