From: Florian Weimer <fw@deneb•enyo.de>
To: Eric Wong <normalperson@yhbt•net>
Cc: git@vger•kernel.org
Subject: Re: Feature request: git-svn dcommit should send deltas upstream
Date: Fri, 29 Aug 2008 12:17:02 +0200 [thread overview]
Message-ID: <87tzd4p1lt.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20080829082311.GA7128@yp-box.dyndns.org> (Eric Wong's message of "Fri, 29 Aug 2008 01:23:11 -0700")
* Eric Wong:
> Florian Weimer <fw@deneb•enyo.de> wrote:
>> Looking at my network traffic and the Perl code, it seems to me that
>> git-svn fails to create a diff (delta) before sending data to the
>> server. As a result, a few changes in a multi-megabyte file lead to a
>> large upload (similar to the situation with CVS). git-svn should be
>> able to compute this diff in all cases because it has got an up-to-date
>> copy of the current revision in the Subversion repository.
>>
>> As far as I can tell, this can't be fixed with a one-liner; some handles
>> need to be passed down to the code that actually handles the upload.
>
> Odd. Can you verify that svn(1) does not send full files in this case,
> too?
These two are pcap files of single-line edits to the same file:
-rw-r--r-- 1 root root 1.3M 2008-08-29 11:54 /tmp/git
-rw-r--r-- 1 root root 40K 2008-08-29 11:53 /tmp/svn
> It's been too long since I've looked at the SVN TxDelta API, but I
> thought SVN::TxDelta::apply would take care of the delta computation for
> us...
SVN::Git::Editor::M does not seem to make use of the base text.
next prev parent reply other threads:[~2008-08-29 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 10:54 Feature request: git-svn dcommit should send deltas upstream Florian Weimer
2008-08-29 8:23 ` Eric Wong
2008-08-29 10:17 ` Florian Weimer [this message]
2008-08-31 16:14 ` Florian Weimer
2008-08-31 17:03 ` Junio C Hamano
2008-08-31 17:13 ` Florian Weimer
2008-09-01 3:41 ` Eric Wong
2008-09-01 8:09 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzd4p1lt.fsf@mid.deneb.enyo.de \
--to=fw@deneb$(echo .)enyo.de \
--cc=git@vger$(echo .)kernel.org \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox