Subject: Re: [PATCH 5/8] builtin/pack-objects: simplify logic to find kept or nonlocal objects

From: Toon Claes <[email-masked]>
Date: Thu, 30 Oct 2025 10:31:17 +0100

Patrick Steinhardt <[email-masked]> writes:

> +		/*
> +		 * We have already checked `last_found`, so there is no need to
> +		 * re-check here.
> +		 */
> +		if (p == last_found && last_found != (void *)1)
> +			continue;

Unrelated to the (void *)1 check, shouldn't this be in the beginning of
the loop?

-- 
Cheers,
Toon