From: Ralph Seichter <github@seichter•de>
To: rsbecker@nexbridge•com, 'Ralph Seichter' <github@seichter•de>,
'Junio C Hamano' <gitster@pobox•com>
Cc: gitgitgadget@gmail•com, git@vger•kernel.org
Subject: RE: [PATCH] Allow git-config to append a comment
Date: Thu, 07 Mar 2024 16:57:16 +0100 [thread overview]
Message-ID: <87wmqevxur.fsf@ra.horus-it.com> (raw)
In-Reply-To: <09c501da70a5$bd2f4f40$378dedc0$@nexbridge.com>
* rsbecker@nexbridge•com:
> My purpose is just to highlight, for the purpose of reviewing the
> change, that there may be unintended impacts, that's all.
I see. Have you perhaps spotted a flaw in the patch which might cause
problems? If so, I'd like to address it.
> With git config moving comments around, responsibility shifts to git -
> a.k.a., unintended consequences.
It is important to note that my implementation does not engage in
"moving comments around" at all. It merely supports adding comment
suffixes to config lines *while they are created by git-config*. No
after-the-fact comment manipulation is done. There are no multiline
comments involved either, which I should have mentioned from the get-go.
The limited scope of my proposal is deliberate, and aimed at avoiding
possible problems based on the design alone.
-Ralph
next prev parent reply other threads:[~2024-03-07 15:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 6:00 [PATCH] Allow git-config to append a comment Ralph Seichter via GitGitGadget
2024-03-06 16:01 ` Junio C Hamano
2024-03-06 17:24 ` Ralph Seichter
2024-03-07 12:12 ` Junio C Hamano
2024-03-07 12:44 ` Ralph Seichter
2024-03-07 13:27 ` Junio C Hamano
2024-03-07 13:53 ` rsbecker
2024-03-07 15:26 ` Ralph Seichter
2024-03-07 15:40 ` rsbecker
2024-03-07 15:57 ` Ralph Seichter [this message]
2024-03-07 15:15 ` [PATCH v2] config: add --comment option to add " Ralph Seichter via GitGitGadget
2024-03-11 12:55 ` Junio C Hamano
2024-03-11 16:17 ` Dragan Simic
2024-03-11 16:48 ` rsbecker
2024-03-11 17:00 ` Dragan Simic
2024-03-11 17:52 ` Dragan Simic
2024-03-11 17:29 ` Junio C Hamano
2024-03-11 17:34 ` Dragan Simic
2024-03-11 19:54 ` Junio C Hamano
2024-03-12 2:25 ` Dragan Simic
2024-03-11 18:23 ` Ralph Seichter
2024-03-11 18:50 ` Dragan Simic
2024-03-11 18:57 ` Ralph Seichter
2024-03-11 19:04 ` Dragan Simic
2024-03-11 21:31 ` Junio C Hamano
2024-03-12 2:38 ` Dragan Simic
2024-03-11 19:17 ` rsbecker
2024-03-12 2:27 ` Dragan Simic
2024-03-11 18:16 ` Ralph Seichter
2024-03-11 18:55 ` Dragan Simic
2024-03-11 19:04 ` Ralph Seichter
2024-03-12 6:19 ` Ralph Seichter
2024-03-12 6:37 ` Chris Torek
2024-03-12 7:28 ` Ralph Seichter
2024-03-12 7:44 ` Junio C Hamano
2024-03-12 21:47 ` [PATCH v3] " Ralph Seichter via GitGitGadget
2024-03-15 22:15 ` Junio C Hamano
2024-03-15 22:26 ` [PATCH 3/1] config: allow tweaking whitespace between value and comment Junio C Hamano
2024-03-26 22:06 ` Junio C Hamano
2024-03-26 22:48 ` Ralph Seichter
2024-03-26 23:27 ` Junio C Hamano
2024-03-27 0:27 ` Ralph Seichter
2024-03-27 1:23 ` Dragan Simic
2024-03-27 17:27 ` Junio C Hamano
2024-03-15 23:10 ` [PATCH v3] config: add --comment option to add a comment Eric Sunshine
2024-03-15 23:41 ` Junio C Hamano
2024-03-15 23:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmqevxur.fsf@ra.horus-it.com \
--to=github@seichter$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=rsbecker@nexbridge$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox