From: Thomas Gummerer <t.gummerer@gmail•com>
To: Duy Nguyen <pclouds@gmail•com>
Cc: Git Mailing List <git@vger•kernel.org>,
Junio C Hamano <gitster@pobox•com>,
Jonathan Nieder <jrnieder@gmail•com>
Subject: Re: [PATCH 0/3] Wider exposure for index-v4
Date: Sun, 16 Feb 2014 11:37:39 +0100 [thread overview]
Message-ID: <87wqgvmjgs.fsf@hank.lan> (raw)
In-Reply-To: <CACsJy8BDerqeua6zjGhniy_kxruDk9WuTJY-2zi6m4EpE9=CBg@mail.gmail.com>
Duy Nguyen <pclouds@gmail•com> writes:
> On Sun, Feb 16, 2014 at 2:23 AM, Thomas Gummerer <t.gummerer@gmail•com> wrote:
>> Hi,
>>
>> since index-v5 didn't seem to generate enough interest to be merged, I
>
> I thought there were some comments last time that you were going to
> address and resubmit?
Yes, there were some comments to the last round, which I already fixed
locally, I'd just have to rebase it to make sure it stell applies
cleanly. No responses from Junio to [1] and [2] gave me the impression
that it's not going to be applied. I would be happy to rebase and
submit if there is a chance for it getting in.
[1] http://thread.gmane.org/gmane.comp.version-control.git/238414/focus=239065
[2] http://thread.gmane.org/gmane.comp.version-control.git/232488/focus=233504
>> have a few patches that give users users easier access to index-v4.
>> Until now users have to go into the source code and compile git
>> themselves to use index-v4 by default, or use git-update-index to
>> change the index file to the new version.
>
> Not objecting this, but I think something like [1] would give v4 more
> exposure. Reading the patch again, I think putting that detection code
> in unpack_trees() or git-merge may make more sense because people will
> be advised about upgrading to v4 at the next fast-forward.
Thanks, I forgot about this patch. I still think at least the first two
patches of this series make sense in addition to your patch, allowing
developers to easily run the test suite with index-v4.
> [1] http://article.gmane.org/gmane.comp.version-control.git/216307
>
>> With this patches it's possible to set the default index file format
>> either in gitconfig or in an environment variable. It also simplifies
>> testing index-v4 by adding a Makefile knob to use it for running the
>> test suite. For safety, existing repositories are not changed when
>> the environment or the config variables are set.
>>
>> I'm not sure about the precedence in patch 3, right now the environment
>> variable has precedence, but it should be easy to give the config
>> option precedence over that.
>>
>> Thomas Gummerer (3):
>> introduce GIT_INDEX_VERSION environment variable
>> test-lib: allow setting the index format version
>> read-cache: add index.version config variable
>>
>> Documentation/config.txt | 4 +++
>> Documentation/git.txt | 5 ++++
>> Makefile | 7 +++++
>> read-cache.c | 36 +++++++++++++++++++++++-
>> t/t1600-index.sh | 52 +++++++++++++++++++++++++++++++++++
>> t/t2104-update-index-skip-worktree.sh | 2 ++
>> t/test-lib-functions.sh | 5 ++++
>> t/test-lib.sh | 3 ++
>> 8 files changed, 113 insertions(+), 1 deletion(-)
>> create mode 100755 t/t1600-index.sh
>>
>> --
>> 1.8.3.2
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger•kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Duy
prev parent reply other threads:[~2014-02-16 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 19:23 [PATCH 0/3] Wider exposure for index-v4 Thomas Gummerer
2014-02-15 19:23 ` [PATCH 1/3] introduce GIT_INDEX_VERSION environment variable Thomas Gummerer
2014-02-19 0:31 ` Junio C Hamano
2014-02-21 22:02 ` Thomas Gummerer
2014-02-15 19:23 ` [PATCH 2/3] test-lib: allow setting the index format version Thomas Gummerer
2014-02-19 0:31 ` Junio C Hamano
2014-02-15 19:23 ` [PATCH 3/3] read-cache: add index.version config variable Thomas Gummerer
2014-02-16 2:10 ` Eric Sunshine
2014-02-16 1:16 ` [PATCH 0/3] Wider exposure for index-v4 Duy Nguyen
2014-02-16 10:37 ` Thomas Gummerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqgvmjgs.fsf@hank.lan \
--to=t.gummerer@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
--cc=pclouds@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox