public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Thomas Rast <tr@thomasrast•ch>
To: Kirill Smelkov <kirr@mns•spb.ru>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [PATCH 3/4] line-log: convert to using diff_tree_sha1()
Date: Thu, 06 Feb 2014 22:01:53 +0100	[thread overview]
Message-ID: <87wqh8arb2.fsf@thomasrast.ch> (raw)
In-Reply-To: <0df5c2e1e93e4873bf276f3f500109249fe1afee.1391619218.git.kirr@mns.spb.ru> (Kirill Smelkov's message of "Wed, 5 Feb 2014 20:57:11 +0400")

Kirill Smelkov <kirr@mns•spb.ru> writes:

> Since diff_tree_sha1() can now accept empty trees via NULL sha1, we
> could just call it without manually reading trees into tree_desc and
> duplicating code.
>
> Cc: Thomas Rast <tr@thomasrast•ch>
> Signed-off-by: Kirill Smelkov <kirr@mns•spb.ru>
> ---
>  line-log.c | 26 ++------------------------
>  1 file changed, 2 insertions(+), 24 deletions(-)

You have to love a diffstat like that :-)

Thanks.

-- 
Thomas Rast
tr@thomasrast•ch

next prev parent reply	other threads:[~2014-02-06 21:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-05 16:57 [PATCH 0/4] Teach diff_tree_sha1() to accept NULL sha1 for empty trees Kirill Smelkov
2014-02-05 16:57 ` [PATCH 1/4] tree-diff: allow diff_tree_sha1 to accept NULL sha1 Kirill Smelkov
2014-02-05 16:57 ` [PATCH 2/4] tree-diff: convert diff_root_tree_sha1() to just call diff_tree_sha1 with old=NULL Kirill Smelkov
2014-02-05 16:57 ` [PATCH 3/4] line-log: convert to using diff_tree_sha1() Kirill Smelkov
2014-02-06 21:01   ` Thomas Rast [this message]
2014-02-06 21:50     ` Junio C Hamano
2014-02-05 16:57 ` [PATCH 4/4] revision: " Kirill Smelkov
2014-02-05 17:25   ` Jeff King
2014-02-05 17:25 ` [PATCH 0/4] Teach diff_tree_sha1() to accept NULL sha1 for empty trees Jeff King
2014-02-05 18:52 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqh8arb2.fsf@thomasrast.ch \
    --to=tr@thomasrast$(echo .)ch \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=kirr@mns$(echo .)spb.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox