public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jim Meyering <jim@meyering•net>
To: Andy Parkins <andyparkins@gmail•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] hooks--update: new, required, config variable: hooks.envelopesender,
Date: Fri, 23 Mar 2007 14:29:06 +0100	[thread overview]
Message-ID: <87wt186qcd.fsf@rho.meyering.net> (raw)
In-Reply-To: <200703231258.34339.andyparkins@gmail.com> (Andy Parkins's message of "Fri, 23 Mar 2007 12:58:31 +0000")

Andy Parkins <andyparkins@gmail•com> wrote:
> On Friday 2007 March 23 12:11, Jim Meyering wrote:
>> This change adds a new, required, config variable: hooks.envelopesender,
>> and use that with sendmail's -f option.  This is important in order
>> to avoid relying on sendmail's "guess" at an appropriate envelope
>> sender address.  Without this, and in the presence of strict servers,
>> it is far too easy not ever to be notified, or (more insidious) never
>> to receive bounce email.
>
> Won't work.

Thanks for the quick feedback.

It works for me using the sendmail from sendmail, and I have tested
this with the one from postfix, too.

>>From "man sendmail" (although my sendmail is actually exim)
...
> The hook scripts run under the identity of the user doing the push; so "-f"
> won't have an effect.

It has a dramatic effect for me.
With it, mail is sent, without, it's not.

> I'm not sure why you would even need it; as the above quote says, the sender
> is set up as the user who ran the command.

Part of the problem was that sendmail used a mangled hostname.
Without -f, it would use user@foo•domain.com.domain.com.

But IMHO, relying on the current behavior (using envelope sender same as
the From: address) is not an option.  It must be configurable.  I want
the envelope sender to be the same admin address for all outgoing mail,
since that's where reports of delivery problems are sent.  Besides, the
users in question don't even have "real" shell or email access on the server
system, so receiving systems would not be able to authenticate them.

In fact, some of the "users" in question are fake accounts used solely
for write access (via git-server) to the shared git repository, so the
user name exists only on the server system.

If we can't do this portably via the sendmail program, then
perhaps it's a good time to switch to using a module like Net::SMTP.

next prev parent reply	other threads:[~2007-03-23 13:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-23 12:11 [PATCH] hooks--update: new, required, config variable: hooks.envelopesender, Jim Meyering
2007-03-23 12:58 ` Andy Parkins
2007-03-23 13:29   ` Jim Meyering [this message]
2007-03-23 14:05     ` Jakub Narebski
2007-03-23 14:12     ` Andy Parkins
2007-03-23 15:25       ` Jim Meyering
2007-03-23 16:15         ` Andy Parkins
2007-03-24 11:27           ` Jim Meyering
2007-03-24 12:16             ` Andy Parkins
2007-03-24 19:58               ` [PATCH] hooks--update: new, optional, config variable: hooks.envelopesender Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wt186qcd.fsf@rho.meyering.net \
    --to=jim@meyering$(echo .)net \
    --cc=andyparkins@gmail$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox