Subject: Re: [PATCH v2] Bump core.deltaBaseCacheLimit to 128MiB

From: David Kastrup <[email-masked]>
Date: Fri, 21 Mar 2014 07:04:17 +0100

Junio C Hamano <[email-masked]> writes:

> David Kastrup <[email-masked]> writes:
>
>> Junio C Hamano <[email-masked]> writes:
>>
>>> Duy Nguyen <[email-masked]> writes:
>>>
>>>> The only
>>>> downside I see is large blobs will be packed  undeltified, which could
>>>> increase pack size if you have lots of them.
>>>
>>> I think that is something that can be tweaked, unless the user tells
>>> us otherwise via command line override, when running the improved
>>> "gc --aggressive" ;-)
>>
>> deltaBaseCacheLimit is used for unpacking, not for packing.
>
> Hmm, doesn't packing need to read existing data?

Judging from the frequent out-of-memory conditions of git gc
--aggressive, packing is not restrained by deltaBaseCacheLimit.

-- 
David Kastrup