From: Sergei Organov <osv@javad•com>
To: <vanicat@debian•org>
Cc: git@vger•kernel.org, Alexandre Julliard <julliard@winehq•org>
Subject: Re: [PATCH] Add function to checkout a branch in git.el
Date: Wed, 13 Feb 2008 21:29:21 +0300 [thread overview]
Message-ID: <87y79ovhfi.fsf@osv.gnss.ru> (raw)
In-Reply-To: <87wsp8u9m7.dlv@maison.homelinux.org> (utf's message of "Wed\, 13 Feb 2008 16\:53\:12 +0100")
<vanicat@debian•org> writes:
> One can now:
> - checkout an existing branch with M-x git-change-branch
> - create and checkout a new branch with C-u M-x git-change-branch
s/git-change-branch/git-checkout/? I mean is there any reason it is
called differently from GIT's "git checkout"?
Besides, I also think that prefix is not a good idea for this kind of
stuff (see my other reply in this thread).
> - do all this from the Git menu
> ---
> It could also be interesting to add some key biding for those
>
> Also one might want to update the *git-status* buffer after checkout,
> but this is not done by this patch
Why? Isn't it as simple as calling (git-refresh-status) at the end of
git-change-branch?
> contrib/emacs/git.el | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 45 insertions(+), 0 deletions(-)
>
> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
> index a8bf0ef..404c8e6 100644
> --- a/contrib/emacs/git.el
> +++ b/contrib/emacs/git.el
> @@ -1138,6 +1138,50 @@ Return the list of files that haven't been handled."
> (when (eq (window-buffer) (current-buffer))
> (shrink-window-if-larger-than-buffer)))
>
> +(defun git-list-branch ()
> + "Return a list of available branch"
s/branch/branches/
> + ;; should I check if I'm in a git repository ?
> + (let ((branchs ()))
s/branchs/branches/
-- Sergei.
prev parent reply other threads:[~2008-02-13 18:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 15:53 [PATCH] Add function to checkout a branch in git.el =?utf-8?q?R=C3=A9mi=20Vanicat?=
2008-02-13 16:30 ` Karl Hasselström
2008-02-13 16:43 ` Karl Hasselström
2008-02-13 18:09 ` Remi Vanicat
2008-02-13 18:23 ` Sergei Organov
2008-02-13 21:04 ` Karl Hasselström
2008-02-14 11:47 ` Sergei Organov
2008-02-16 19:17 ` [patch v2] switching and creating branch, merging and rebasing with Emacs =?utf-8?q?R=C3=A9mi=20Vanicat?=
2008-02-16 19:27 ` [PATCH 01/03] Add helper function for branch tag and commitish to git.el Rémi Vanicat
2008-02-17 18:30 ` Alexandre Julliard
2008-02-16 19:30 ` [PATCH 02/03] Adding checkout function for commitish in git.el Rémi Vanicat
2008-02-17 18:27 ` Alexandre Julliard
2008-02-16 19:35 ` [PATCH 03/03] Adding command for merging " Rémi Vanicat
2008-02-13 18:29 ` Sergei Organov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y79ovhfi.fsf@osv.gnss.ru \
--to=osv@javad$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=julliard@winehq$(echo .)org \
--cc=vanicat@debian$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox