Subject: Re: [PATCH v5 1/3] test-lib: allow selecting tests by substring/glob with --run

From: Andrei Rybak <[email-masked]>
Date: Sat, 17 Oct 2020 01:25:57 +0200

On 2020-10-17 00:50, Elijah Newren via GitGitGadget wrote:

[trim]

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index ef31f40037..debfd73fd6 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -769,6 +769,8 @@ match_pattern_list () {
>  }
>  
>  match_test_selector_list () {
> +	operation="$1"
> +	shift
>  	title="$1"
>  	shift
>  	arg="$1"
> @@ -777,7 +779,7 @@ match_test_selector_list () {
>  
>  	# Both commas and whitespace are accepted as separators.

This comment becomes outdated with the change below.

>  	OLDIFS=$IFS
> -	IFS=' 	,'
> +	IFS=','
>  	set -- $1
>  	IFS=$OLDIFS
>  
> @@ -805,13 +807,13 @@ match_test_selector_list () {