Subject: Re: [PATCH v3 04/11] bundle-uri client: add boolean transfer.bundleURI setting

From: Derrick Stolee <[email-masked]>
Date: Wed, 7 Dec 2022 10:20:11 -0500

On 12/5/2022 6:32 PM, Victoria Dye wrote:
> Ævar Arnfjörð Bjarmason via GitGitGadget wrote:
>> +	# Client did not issue bundle-uri command
>> +	! grep "> command=bundle-uri" log &&
>> +
>> +	GIT_TRACE_PACKET="$PWD/log" \
>> +	git \
>> +		-c transfer.bundleURI=true \
>> +		-c protocol.version=2 \
>> +		clone "$BUNDLE_URI_REPO_URI" cloned2 \
>> +		>actual 2>err &&
>
> If 'GIT_TEST_BUNDLE_URI' is set to '1' in a more global scope (by a CI job
> or user running the tests), then the '-c transfer.bundleURI' config isn't
> actually what's enabling the behavior. To make this more directly comparable
> to the case earlier in this test, could you add 'GIT_TEST_BUNDLE_URI=0' here
> as well?

You're right that GIT_TEST_BUNDLE_URI is not needed if we can set
transfer.bundleURI globally earlier in the test. It doesn't make much sense
to run the entire test suite with it on, since the server side does not
advertise bundles unless explicitly configured to do so.

Thanks,
-Stolee