From: Johannes Schindelin <Johannes.Schindelin@gmx•de>
To: Delilah Ashley Wu via GitGitGadget <gitgitgadget@gmail•com>
Cc: git@vger•kernel.org, Delilah Ashley Wu <delilahwu@microsoft•com>,
Derrick Stolee <stolee@gmail•com>,
Patrick Steinhardt <ps@pks•im>,
Delilah Ashley Wu <delilahwu@linux•microsoft.com>
Subject: Re: [PATCH/RFC 0/4] config: read both home and xdg files for --global
Date: Mon, 17 Nov 2025 14:29:33 +0100 (CET) [thread overview]
Message-ID: <8e2b868d-8753-bbcd-840c-8eaefaa7cbd1@gmx.de> (raw)
In-Reply-To: <pull.1938.git.1760058849.gitgitgadget@gmail.com>
Hi,
On Fri, 10 Oct 2025, Delilah Ashley Wu via GitGitGadget wrote:
> As reported in [1]: `$HOME/.gitconfig` and `$XDG_CONFIG_HOME/git/config` are
> both valid global config locations, but `git config list --global` only
> includes the former in its output.
>
> Suppose we have this config in `$HOME/.gitconfig`:
>
> [home]
> config = true
>
>
> And this config in `$XDG_CONFIG_HOME/git/config`:
>
> [xdg]
> config = true
>
>
> Then, to reproduce the issue that `--global` only shows the home config:
>
> $ git config list --global --show-scope --show-origin
> global file:/Users/delilah/.gitconfig home.config=true
>
>
> Git correctly applies the XDG config in its effective configuration, but it
> doesn't show up when `--global` is specified. We can confirm this by
> checking the output without the `--global` flag:
>
> $ git config list --show-scope --show-origin
> global file:/Users/delilah/.config/git/config xdg.config=true
> global file:/Users/delilah/.gitconfig home.config=true
>
>
> The expected behaviour is both configs should be shown when `--global` is
> specified, so we'd expect its output to look the same as above. This was
> confirmed in [2], which quoted the `git config` documentation:
>
> > OPTIONS
> > --global::
> > For writing options: write to global `~/.gitconfig` file
> > rather than the repository `.git/config`, write to
> > `$XDG_CONFIG_HOME/git/config` file if this file exists and the
> > `~/.gitconfig` file doesn't.
> >
> > For reading options: read only from global `~/.gitconfig` and from
> > `$XDG_CONFIG_HOME/git/config` rather than from all available files.
>
>
> The first patch fixes forward slash normalisation on Windows paths. The
> second patch introduces tests and regression checks. The third and fourth
> patches implement the fix to include both config files when `--global` is
> specified. Johannes has kindly pre-reviewed this patch series via GitHub on
> GitGitGadget #1938 [3]. You'll notice some force-pushes after the review,
> but I only changed commit messages.
>
> [1]:
> https://lore.kernel.org/git/CAFA9we-QLQRzJdGMMCPatmfrk1oHeiUu9msMRXXk1MLE5HRxBQ@mail.gmail.com/
> [2]: https://lore.kernel.org/git/xmqqmt5lezi3.fsf@gitster.g/
> [3]: https://github.com/gitgitgadget/git/pull/1938/
>
> Thank you all for your time!
For the record, my "Reviewed-by:" still stands, if lack of reviews should
be the reason why this patch series has not even entered the `seen`
branch.
Ciao,
Johannes
next prev parent reply other threads:[~2025-11-17 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 1:14 [PATCH/RFC 0/4] config: read both home and xdg files for --global Delilah Ashley Wu via GitGitGadget
2025-10-10 1:14 ` [PATCH/RFC 1/4] cleanup_path: force forward slashes on Windows Delilah Ashley Wu via GitGitGadget
2025-11-19 17:47 ` Junio C Hamano
2025-10-10 1:14 ` [PATCH/RFC 2/4] config: test home and xdg files in `list --global` Delilah Ashley Wu via GitGitGadget
2025-11-19 18:29 ` Junio C Hamano
2025-10-10 1:14 ` [PATCH/RFC 3/4] config: read global scope via config_sequence Delilah Ashley Wu via GitGitGadget
2025-11-19 18:39 ` Junio C Hamano
2025-10-10 1:14 ` [PATCH/RFC 4/4] config: keep bailing on unreadable global files Delilah Ashley Wu via GitGitGadget
2025-10-10 1:27 ` [PATCH/RFC 0/4] config: read both home and xdg files for --global Kristoffer Haugsbakk
2025-11-22 1:36 ` Delilah Ashley Wu
2026-01-20 20:41 ` Junio C Hamano
2025-11-17 13:29 ` Johannes Schindelin [this message]
2025-11-18 0:28 ` Junio C Hamano
2025-11-19 14:44 ` Junio C Hamano
2025-11-22 2:00 ` Delilah Ashley Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e2b868d-8753-bbcd-840c-8eaefaa7cbd1@gmx.de \
--to=johannes.schindelin@gmx$(echo .)de \
--cc=delilahwu@linux$(echo .)microsoft.com \
--cc=delilahwu@microsoft$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=ps@pks$(echo .)im \
--cc=stolee@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox