From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Jonas Rebmann" <jre@pengutronix•de>, git@vger•kernel.org
Cc: "Junio C Hamano" <gitster@pobox•com>,
"Patrick Steinhardt" <ps@pks•im>,
kernel@pengutronix•de
Subject: Re: [PATCH] GIT-VERSION-GEN: Use standard versioning suffix
Date: Fri, 05 Sep 2025 14:32:52 +0200 [thread overview]
Message-ID: <8e8255bf-79d0-41ee-85a9-d664ee01b5ae@app.fastmail.com> (raw)
In-Reply-To: <20250905-semver-v1-1-3f6dd32f71a3@pengutronix.de>
Hi
The following might not be immediately relevant in light of what brian
just wrote.
On Fri, Sep 5, 2025, at 14:14, Jonas Rebmann wrote:
>[snip]
> This is not semver compliant which makes the output harder to parse in
> tooling such as b4, which currently errors out when using a snapshot
> build of git.
>
> For snapshot builds, use as version string the unmodified git-describe
> output with only the leading v stripped from the tag.
>
> Fixes: 5c7d3c9507f7 ("Allow building of RPM from interim snapshot.")
For other readers: this can be traced back to from
• `git log -S'VN=$(echo "$VN"' GIT-VERSION-GEN`
• which finds 374dfaa2e39 (Make GIT-VERSION-GEN tolerate missing git
describe command again, 2006-01-26)
• which in turn references this 5c7d3c9507f (Allow building of RPM from
interim snapshot., 2006-01-16)
This project doesn’t use this Kernel-style trailer.[1] Also not the commit
reference style. (It uses `git show -s --pretty=reference <commit>`)
It’s more common to place it inside the body of the message. Like a
replacement for the preceding “historical reasons”.
† 1: It’s almost only trailers which attribute people. (I am having a hard
time coming up with exceptions; you can find at least
one Cherry-picked-from)
> Signed-off-by: Jonas Rebmann <jre@pengutronix•de>
prev parent reply other threads:[~2025-09-05 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 12:14 [PATCH] GIT-VERSION-GEN: Use standard versioning suffix Jonas Rebmann
2025-09-05 12:19 ` brian m. carlson
2025-09-05 13:43 ` Jonas Rebmann
2025-09-05 15:19 ` Junio C Hamano
2025-09-05 12:32 ` Kristoffer Haugsbakk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e8255bf-79d0-41ee-85a9-d664ee01b5ae@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jre@pengutronix$(echo .)de \
--cc=kernel@pengutronix$(echo .)de \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox