From: Phillip Wood <phillip.wood123@gmail•com>
To: Junio C Hamano <gitster@pobox•com>,
"D. Ben Knoble" <ben.knoble+github@gmail•com>
Cc: git@vger•kernel.org, Phillip Wood <phillip.wood@dunelm•org.uk>,
Taylor Blau <me@ttaylorr•com>, Patrick Steinhardt <ps@pks•im>
Subject: Re: [PATCH 3/5] parseopt: use boolean type for a simple flag
Date: Tue, 4 Nov 2025 16:21:31 +0000 [thread overview]
Message-ID: <962654fc-02ea-47a9-a2ae-913101281240@gmail.com> (raw)
In-Reply-To: <xmqq5xbrwv4t.fsf@gitster.g>
On 03/11/2025 05:19, Junio C Hamano wrote:
> "D. Ben Knoble" <ben.knoble+github@gmail•com> writes:
>
>> is_optional = skip_prefix(value, ":(optional)", &value);
>> if (!value)
>> - is_optional = 0;
>> + is_optional = false;
>
> Whether it is spelled 0 or false, I do not think this makes any
> sense. skip_prefix() either touches &value to point at the
> substring in value that comes after ":(optional)", or it does not
> touch it at all, so there is no way value can be NULL here (and we
> know value is not NULL before we call skip_prefix()).
>
> Shouldn't you be removing the entire "if value is NULL, it is not
> optional" thing instead? That is exactly what Phillip pointed out
> in his review.
Looking at this again I wonder if the intention was to error out if
there wasn't a filename after the ":(optional)" prefix which I think
would be a reasonable thing to do but that's not what this code actually
does.
Thanks
Phillip
next prev parent reply other threads:[~2025-11-04 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-02 16:17 [PATCH 0/5] Fixes for :(optional) path code D. Ben Knoble
2025-11-02 16:17 ` [PATCH 1/5] parseopt: fix :(optional) at command line to only ignore missing files D. Ben Knoble
2025-11-04 16:19 ` Phillip Wood
2025-11-04 17:24 ` Junio C Hamano
2025-11-04 17:34 ` Junio C Hamano
2025-11-04 18:24 ` D. Ben Knoble
2025-11-05 16:35 ` Phillip Wood
2025-11-06 17:47 ` Junio C Hamano
2025-11-02 16:17 ` [PATCH 2/5] doc: clarify command equivalence comment D. Ben Knoble
2025-11-02 16:17 ` [PATCH 3/5] parseopt: use boolean type for a simple flag D. Ben Knoble
2025-11-03 5:19 ` Junio C Hamano
2025-11-04 16:21 ` Phillip Wood [this message]
2025-11-04 18:22 ` D. Ben Knoble
2025-11-02 16:17 ` [PATCH 4/5] config: " D. Ben Knoble
2025-11-02 16:17 ` [PATCH 5/5] parseopt: restore const qualifier to parsed filename D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=962654fc-02ea-47a9-a2ae-913101281240@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=ben.knoble+github@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=me@ttaylorr$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox