From: Siddh Raman Pant <siddh.raman.pant@oracle•com>
To: "git@vger•kernel.org" <git@vger•kernel.org>
Cc: "oswald.buddenhagen@gmx•de" <oswald.buddenhagen@gmx•de>,
"gitster@pobox•com" <gitster@pobox•com>,
"code@khaugsbakk•name" <code@khaugsbakk•name>,
"j6t@kdbg•org" <j6t@kdbg•org>, "peff@peff•net" <peff@peff•net>,
"ps@pks•im" <ps@pks•im>,
"sandals@crustytoothpaste•net" <sandals@crustytoothpaste•net>,
"newren@gmail•com" <newren@gmail•com>
Subject: Re: [PATCH v3 0/4] Add support for an external command for fetching notes
Date: Thu, 28 May 2026 05:59:02 +0000 [thread overview]
Message-ID: <963cf0c8667a2f3cc286988a4ca01284c14a90be.camel@oracle.com> (raw)
In-Reply-To: <cover.1779532562.git.siddh.raman.pant@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 3389 bytes --]
Hi,
Pinging since it's been almost a week (v2 was sent on Fri)...
I sent close/during the weekend, so I think this fell through.
Sorry if this bothers. Just curious as I haven't heard back like the
last time.
Thanks,
Siddh
On Sat, May 23 2026 at 16:08:08 +0530, Siddh Raman Pant wrote:
> v2: https://lore.kernel.org/git/cover.1779464886.git.siddh.raman.pant@oracle.com/
> v1: https://lore.kernel.org/git/cover.1779207350.git.siddh.raman.pant@oracle.com/
>
> <...insert text from v1 cover here...>
>
> Changes since v2:
> - Removed stale help text talking about force-killing helper process.
>
> Changes since v1:
> - Removed Documentation commit and sent as a standalone patch.
> - Removed finish_command_with_timeout addition (and thus sleep_nanosec).
> - Squashed the external notes command code, doc, and test commits.
> - Removed horizontal separators from note-external.c.
> - Removed global variables from translation unit and instead store config in
> a dedicated new struct member in struct display_notes_opt.
> - Reworded the main commit to have better explanation of the motivation.
>
> Siddh Raman Pant (4):
> notes: convert raw arg in format_display_notes() to bool
> wrapper: add support for timeout and deadline in read helpers
> t3301: cover generic displayed notes behavior
> notes: support an external command to display notes
>
> Documentation/config/notes.adoc | 59 +++
> Documentation/git-format-patch.adoc | 11 +-
> Documentation/git-range-diff.adoc | 6 +
> Documentation/pretty-options.adoc | 9 +
> Makefile | 2 +
> builtin/log.c | 17 +-
> builtin/name-rev.c | 9 +-
> builtin/range-diff.c | 2 +
> contrib/completion/git-completion.bash | 4 +-
> log-tree.c | 10 +-
> meson.build | 1 +
> notes-external.c | 414 ++++++++++++++++++
> notes-external.h | 53 +++
> notes.c | 266 +++++++++---
> notes.h | 33 +-
> revision.c | 36 +-
> strbuf.c | 26 +-
> strbuf.h | 4 +
> t/helper/meson.build | 1 +
> t/helper/test-external-notes | 64 +++
> t/helper/test-notes-external-config-reset.c | 24 ++
> t/helper/test-tool.c | 1 +
> t/helper/test-tool.h | 1 +
> t/lib-notes.sh | 19 +
> t/t3206-range-diff.sh | 68 +++
> t/t3301-notes.sh | 448 ++++++++++++++++++++
> t/t6120-describe.sh | 17 +
> wrapper.c | 139 +++++-
> wrapper.h | 23 +
> 29 files changed, 1691 insertions(+), 76 deletions(-)
> create mode 100644 notes-external.c
> create mode 100644 notes-external.h
> create mode 100755 t/helper/test-external-notes
> create mode 100644 t/helper/test-notes-external-config-reset.c
> create mode 100644 t/lib-notes.sh
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-28 5:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 10:38 [PATCH v3 0/4] Add support for an external command for fetching notes Siddh Raman Pant
2026-05-23 10:38 ` [PATCH v3 1/4] notes: convert raw arg in format_display_notes() to bool Siddh Raman Pant
2026-05-23 10:38 ` [PATCH v3 2/4] wrapper: add support for timeout and deadline in read helpers Siddh Raman Pant
2026-05-23 10:38 ` [PATCH v3 3/4] t3301: cover generic displayed notes behavior Siddh Raman Pant
2026-05-23 10:38 ` [PATCH v3 4/4] notes: support an external command to display notes Siddh Raman Pant
2026-05-28 5:59 ` Siddh Raman Pant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963cf0c8667a2f3cc286988a4ca01284c14a90be.camel@oracle.com \
--to=siddh.raman.pant@oracle$(echo .)com \
--cc=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=j6t@kdbg$(echo .)org \
--cc=newren@gmail$(echo .)com \
--cc=oswald.buddenhagen@gmx$(echo .)de \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox