From: "D. Ben Knoble" <ben.knoble+github@gmail•com>
To: git@vger•kernel.org
Cc: "D. Ben Knoble" <ben.knoble+github@gmail•com>,
Kristoffer Haugsbakk <code@khaugsbakk•name>,
Elijah Newren <newren@gmail•com>,
Christian Couder <chriscool@tuxfamily•org>,
"brian m. carlson" <sandals@crustytoothpaste•net>,
Sergey Organov <sorganov@gmail•com>,
Junio C Hamano <gitster@pobox•com>
Subject: [PATCH v2] replay: drop rev-list formatting options from manual
Date: Tue, 20 Jan 2026 09:05:57 -0500 [thread overview]
Message-ID: <97ae3ba465511d1ff73b11efb55d393ac5a4d9d0.1768917929.git.ben.knoble+github@gmail.com> (raw)
In-Reply-To: <01a7acfaf87494419b3766da57d4c05cf99c79bb.1768873599.git.ben.knoble+github@gmail.com>
The rev-list options in our manuals are quite long; git-replay's manual
is no exception. Since replay doesn't use the formatting options at all
(it has its own output format), drop them.
This is the first time we have needed compound tests [1] for if[n]def in
our documentation:
git grep '^ifn\?def::' Documentation | grep '[,+]'
[1]: https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/
For both ifdef and ifndef, the "," takes on the intuitive meaning:
- ifdef: if any of the listed attributes are set…
- ifndef: unless any of the listed attributes are set
(Use "+" for "all".)
Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail•com>
---
Documentation/git-replay.adoc | 1 +
Documentation/rev-list-options.adoc | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-replay.adoc b/Documentation/git-replay.adoc
index 4c61f3aa1f..c3b214ec69 100644
--- a/Documentation/git-replay.adoc
+++ b/Documentation/git-replay.adoc
@@ -64,6 +64,7 @@ The default mode can be configured via the `replay.refAction` configuration vari
range should have a single tip, so that it's clear to which tip the
advanced <branch> should point.
+:git-replay: 1
include::rev-list-options.adoc[]
[[output]]
diff --git a/Documentation/rev-list-options.adoc b/Documentation/rev-list-options.adoc
index 453ec59057..c4d7a6b989 100644
--- a/Documentation/rev-list-options.adoc
+++ b/Documentation/rev-list-options.adoc
@@ -1096,7 +1096,7 @@ endif::git-rev-list[]
Overrides a previous `--no-walk`.
endif::git-shortlog[]
-ifndef::git-shortlog[]
+ifndef::git-shortlog,git-replay[]
Commit Formatting
~~~~~~~~~~~~~~~~~
@@ -1265,4 +1265,4 @@ ifdef::git-rev-list[]
counts and print the count for equivalent commits separated
by a tab.
endif::git-rev-list[]
-endif::git-shortlog[]
+endif::git-shortlog,git-replay[]
Diff-intervalle contre v1 :
1: 01a7acfaf8 ! 1: 97ae3ba465 replay: drop rev-list formatting options from manual
@@ Commit message
is no exception. Since replay doesn't use the formatting options at all
(it has its own output format), drop them.
+ This is the first time we have needed compound tests [1] for if[n]def in
+ our documentation:
- ## Notes (benknoble/commits) ##
- I noticed this while reading. It took me a minute to find the
- Asciidoc reference on multiple attributes [1] since it's not used
- elsewhere in the rev-list include :) I'm not sure it needs to be
- included in the commit message, though normally I would, personally.
+ git grep '^ifn\?def::' Documentation | grep '[,+]'
[1]: https://docs.asciidoctor.org/asciidoc/latest/directives/ifdef-ifndef/
+ For both ifdef and ifndef, the "," takes on the intuitive meaning:
+ - ifdef: if any of the listed attributes are set…
+ - ifndef: unless any of the listed attributes are set
+
+ (Use "+" for "all".)
+
## Documentation/git-replay.adoc ##
@@ Documentation/git-replay.adoc: The default mode can be configured via the `replay.refAction` configuration vari
range should have a single tip, so that it's clear to which tip the
base-commit: b5c409c40f1595e3e590760c6f14a16b6683e22c
--
2.52.0.rc0.569.g0e1cb519e9.dirty
prev parent reply other threads:[~2026-01-20 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 1:47 [PATCH] replay: drop rev-list formatting options from manual D. Ben Knoble
2026-01-20 2:19 ` Junio C Hamano
2026-01-20 14:04 ` D. Ben Knoble
2026-01-20 15:37 ` Junio C Hamano
2026-01-20 21:49 ` Junio C Hamano
2026-01-20 23:11 ` Junio C Hamano
2026-01-21 13:27 ` Jean-Noël Avila
2026-01-21 16:26 ` Junio C Hamano
2026-01-21 20:03 ` D. Ben Knoble
2026-01-27 18:48 ` D. Ben Knoble
2026-01-20 14:05 ` D. Ben Knoble [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ae3ba465511d1ff73b11efb55d393ac5a4d9d0.1768917929.git.ben.knoble+github@gmail.com \
--to=ben.knoble+github@gmail$(echo .)com \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=newren@gmail$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
--cc=sorganov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox