From: Ben Knoble <ben.knoble@gmail•com>
To: Junio C Hamano <gitster@pobox•com>
Cc: "D. Ben Knoble" <ben.knoble+github@gmail•com>,
"Kristoffer Haugsbakk" <code@khaugsbakk•name>,
git@vger•kernel.org, "Phillip Wood" <phillip.wood123@gmail•com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
"Glen Choo" <glencbz@gmail•com>,
"Karthik Nayak" <karthik.188@gmail•com>,
"Denton Liu" <liu.denton@gmail•com>,
motisd8@gmail•com, "Phillip Wood" <phillip.wood@dunelm•org.uk>,
"Patrick Steinhardt" <ps@pks•im>
Subject: Re: [PATCH] doc: explain the impact of stash.index on --autostash options
Date: Sun, 12 Oct 2025 14:04:22 -0400 [thread overview]
Message-ID: <B78CD1B1-67C1-4EA1-94A7-13AD40C43585@gmail.com> (raw)
In-Reply-To: <xmqqy0ph5ov8.fsf@gitster.g>
>
> Le 11 oct. 2025 à 13:29, Junio C Hamano <gitster@pobox•com> a écrit :
>
> "D. Ben Knoble" <ben.knoble+github@gmail•com> writes:
>
>>> On Thu, Oct 9, 2025 at 6:55 PM Kristoffer Haugsbakk
>>> <code@khaugsbakk•name> wrote:
>>>
>>> This is over-specified IMO. Like mentioned this patch could be applied
>>> on top of commit 9842c0c749. Then that merge commit will not be
>>> reachable from this resulting commit.
>>>
>>> I also don’t see the point of mentioning when things were merged in in
>>> the commit message.
>
> Yeah, that is less useful to me (there is a tool, given a commit
> object, to figure out at which merge it got merged to the mainline);
> I didn't think of a way the information can be useful to general
> readers. If the mainline merge was a release or more ago, then it
> may make sense to say "commit X, which appeared in version Y, was
> broken in such and such way, and here is to fix its breakage"
It’s not clear to me if you’d like to see a v2 or not, but given you were already happy to merge in the latest what’s cooking, I don’t mind not sending one ;)
next prev parent reply other threads:[~2025-10-12 18:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-10 18:33 [PATCH 0/9] make stash apply with --index by default D. Ben Knoble
2025-05-10 18:33 ` [PATCH 1/9] t3903: reduce dependencies on previous tests D. Ben Knoble
2025-05-10 18:33 ` [PATCH 2/9] t3905: remove unneeded blank line D. Ben Knoble
2025-05-10 18:33 ` [PATCH 3/9] BreakingChanges: announce stash {apply,pop} will imply --index D. Ben Knoble
2025-05-10 18:33 ` [PATCH 4/9] stash: restore the index by default when breaking changes are enabled D. Ben Knoble
2025-05-10 18:33 ` [PATCH 5/9] t0450: mark stash documentation as a known discrepancy D. Ben Knoble
2025-05-10 18:33 ` [PATCH 6/9] t3903: adjust stash test to account for --[no-]index with breaking changes D. Ben Knoble
2025-05-10 18:33 ` [PATCH 7/9] t3904: adjust stash -p test to account for index states " D. Ben Knoble
2025-05-10 18:33 ` [PATCH 8/9] t3905: adjust stash -u tests for " D. Ben Knoble
2025-05-10 18:33 ` [PATCH 9/9] t3906: adjust stash submodule tests to account " D. Ben Knoble
2025-05-12 12:52 ` [PATCH 0/9] make stash apply with --index by default Junio C Hamano
2025-05-20 14:36 ` D. Ben Knoble
2025-05-20 14:39 ` D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 0/4] Teach git-stash to use --index from config D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 1/4] t3903: reduce dependencies on previous tests D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 2/4] t3905: remove unneeded blank line D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 3/4] stash: refactor private config globals D. Ben Knoble
2025-09-16 0:37 ` [PATCH v2 4/4] stash: honor stash.index in apply, pop modes D. Ben Knoble
2025-09-16 9:18 ` Phillip Wood
2025-09-16 17:07 ` D. Ben Knoble
2025-09-16 9:24 ` [PATCH v2 0/4] Teach git-stash to use --index from config Phillip Wood
2025-09-16 17:06 ` D. Ben Knoble
2025-09-16 16:49 ` Junio C Hamano
2025-09-22 1:39 ` [PATCH v3 " D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 1/4] t3903: reduce dependencies on previous tests D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 2/4] t3905: remove unneeded blank line D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 3/4] stash: refactor private config globals D. Ben Knoble
2025-09-22 1:39 ` [PATCH v3 4/4] stash: honor stash.index in apply, pop modes D. Ben Knoble
2025-09-22 14:11 ` Phillip Wood
2025-09-24 20:40 ` D. Ben Knoble
2025-09-29 10:01 ` Phillip Wood
2025-10-06 12:59 ` [PATCH] doc: explain the impact of stash.index on --autostash options D. Ben Knoble
2025-10-09 22:54 ` Kristoffer Haugsbakk
2025-10-11 14:44 ` D. Ben Knoble
2025-10-11 17:28 ` Junio C Hamano
2025-10-12 18:04 ` Ben Knoble [this message]
2025-10-13 12:17 ` Kristoffer Haugsbakk
2025-10-14 2:18 ` D. Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B78CD1B1-67C1-4EA1-94A7-13AD40C43585@gmail.com \
--to=ben.knoble@gmail$(echo .)com \
--cc=avarab@gmail$(echo .)com \
--cc=ben.knoble+github@gmail$(echo .)com \
--cc=code@khaugsbakk$(echo .)name \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=glencbz@gmail$(echo .)com \
--cc=karthik.188@gmail$(echo .)com \
--cc=liu.denton@gmail$(echo .)com \
--cc=motisd8@gmail$(echo .)com \
--cc=phillip.wood123@gmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox