From: "Ghanshyam Thakkar" <shyamthakkar001@gmail•com>
To: "Junio C Hamano" <gitster@pobox•com>
Cc: <git@vger•kernel.org>
Subject: Re: [PATCH 2/2] t0024: refactor to have single command per line
Date: Fri, 19 Jan 2024 06:27:27 +0530 [thread overview]
Message-ID: <CYI9WH7UZ58F.GO37VZJHL7QD@gmail.com> (raw)
In-Reply-To: <xmqqfryunsd1.fsf@gitster.g>
On Fri Jan 19, 2024 at 4:48 AM IST, Junio C Hamano wrote:
> > - ( mkdir untarred && cd untarred && "$TAR" -xf ../test.tar ) &&
> > + mkdir untarred &&
> > + (
> > + cd untarred &&
> > + "$TAR" -xf ../test.tar
> > + ) &&
>
> I think we assume "$TAR" is modern enough to know about the "C"
> option (see t/t5004-archive-corner-cases.sh), so
>
> mkdir untarred &&
> "$TAR" Cxf untarred test.tar
>
> without even a subshell may be sufficient.
Will update it in v2.
>
> > @@ -30,7 +34,11 @@ test_expect_success UNZIP 'zip archive' '
> >
> > git archive --format=zip HEAD >test.zip &&
> >
> > - ( mkdir unzipped && cd unzipped && "$GIT_UNZIP" ../test.zip ) &&
> > + mkdir unzipped &&
> > + (
> > + cd unzipped &&
> > + "$GIT_UNZIP" ../test.zip
> > + ) &&
>
> I do not think we assume "$GIT_UNZIP" to always know about the
> equivalent of "C" (is that "-d exdir"?), so what you wrote is the
> best we can do.
Yeah, "-d exdir" would be the equivalent, but there's no mention of it
in the testcases in t5003 or t5004. So, keeping it as is in v2.
Thanks.
next prev parent reply other threads:[~2024-01-19 0:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 21:53 [PATCH 1/2] t0024: avoid losing exit status to pipes Ghanshyam Thakkar
2024-01-18 21:53 ` [PATCH 2/2] t0024: refactor to have single command per line Ghanshyam Thakkar
2024-01-18 23:18 ` Junio C Hamano
2024-01-19 0:57 ` Ghanshyam Thakkar [this message]
2024-01-19 3:40 ` Ghanshyam Thakkar
2024-01-18 23:04 ` [PATCH 1/2] t0024: avoid losing exit status to pipes Junio C Hamano
2024-01-19 1:36 ` [PATCH v2 " Ghanshyam Thakkar
2024-01-19 1:36 ` [PATCH v2 2/2] t0024: style fix Ghanshyam Thakkar
2024-01-19 3:33 ` [PATCH v3 1/2] t0024: avoid losing exit status to pipes Ghanshyam Thakkar
2024-01-19 3:33 ` [PATCH v3 2/2] t0024: style fix Ghanshyam Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYI9WH7UZ58F.GO37VZJHL7QD@gmail.com \
--to=shyamthakkar001@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox