From: "Bence Ferdinandy" <bence@ferdinandy•com>
To: "Junio C Hamano" <gitster@pobox•com>,
"Christian Hesse" <mail@eworm•de>,
"Christian Hesse" <list@eworm•de>
Cc: <git@vger•kernel.org>
Subject: Re: [PATCH] fetch set_head: fix non-mirror remotes in bare repositories
Date: Thu, 23 Jan 2025 22:42:23 +0100 [thread overview]
Message-ID: <D79S38LX7NLS.34MN1BWV0HVJ0@ferdinandy.com> (raw)
In-Reply-To: <xmqqr04tqm86.fsf@gitster.g>
On Thu Jan 23, 2025 at 22:00, Junio C Hamano <gitster@pobox•com> wrote:
> Bence Ferdinandy <bence@ferdinandy•com> writes:
>
>> In b1b713f722 (fetch set_head: handle mirrored bare repositories,
>> 2024-11-22) it was implicitly assumed that all remotes will be mirrors
>> in a bare repository, thus fetching a non-mirrored remote could lead to
>> HEAD pointing to a non-existent reference. Make sure we only overwrite
>> HEAD if we are in a bare repository and fetching from a mirror.
>> Otherwise, proceed as normally, and create
>> refs/remotes/<nonmirrorremote>/HEAD instead.
>>
>> Signed-off-by: Bence Ferdinandy <bence@ferdinandy•com>
>> Reported-by: Christian Hesse <list@eworm•de>
>
> These should be chronological; somebody reports an issue, the patch
> gets written, and finally it is sent out with a Sign-off to certify
> that the patch is not a stolen property.
Makes sense, I'll send a v2 in that case.
>
>> ---
>> builtin/fetch.c | 15 ++++++++-------
>> t/t5505-remote.sh | 10 ++++++++++
>> t/t5510-fetch.sh | 13 +++++++++++++
>> 3 files changed, 31 insertions(+), 7 deletions(-)
>
> We haven't heard from Chritian; has this been tested OK?
To the extent of the tests I've added, but I'm not aware of anybody else,
especially Christian trying it out.
>
> What the patch does does look sensible. Thanks.
Thanks,
Bence
next prev parent reply other threads:[~2025-01-23 21:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-11 19:26 fatal: Not a valid object name HEAD Christian Hesse
2025-01-12 14:17 ` Bence Ferdinandy
2025-01-13 16:30 ` Junio C Hamano
2025-01-12 16:51 ` [PATCH] fetch set_head: fix non-mirror remotes in bare repositories Bence Ferdinandy
2025-01-23 21:00 ` Junio C Hamano
2025-01-23 21:42 ` Bence Ferdinandy [this message]
2025-01-23 22:00 ` Eric Sunshine
2025-01-24 14:07 ` Christian Hesse
2025-01-24 17:17 ` Junio C Hamano
2025-01-24 5:56 ` Patrick Steinhardt
2025-01-24 10:30 ` Eric Sunshine
2025-01-24 16:07 ` Junio C Hamano
2025-01-26 22:01 ` Bence Ferdinandy
2025-01-26 22:01 ` Bence Ferdinandy
2025-01-26 22:02 ` [PATCH v2 1/2] fetch set_head: refactor to use remote directly Bence Ferdinandy
2025-01-26 22:02 ` [PATCH v2 2/2] fetch set_head: fix non-mirror remotes in bare repositories Bence Ferdinandy
2025-01-27 7:30 ` Patrick Steinhardt
2025-01-27 20:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D79S38LX7NLS.34MN1BWV0HVJ0@ferdinandy.com \
--to=bence@ferdinandy$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=list@eworm$(echo .)de \
--cc=mail@eworm$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox