From: "Drew DeVault" <drew@ddevault•org>
To: "Aditya Garg" <gargaditya08@live•com>, <git@vger•kernel.org>
Cc: "Martin von Zweigbergk" <martinvonz@google•com>,
"Patrick Steinhardt" <ps@pks•im>,
"Andy Koppe" <andy.koppe@gmail•com>,
"Remo Senekowitsch" <remo@buenzli•dev>,
"Jeff King" <peff@peff•net>
Subject: Re: [PATCH v2 1/2] pretty: add X-Change-ID to mail formats
Date: Sun, 06 Jul 2025 12:41:50 +0200 [thread overview]
Message-ID: <DB4WQTRHWZN3.3VG20AZDK8VN@ddevault.org> (raw)
In-Reply-To: <PN3PR01MB9597069B8CF014BFE01B53F3B84CA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
[-- Attachment #1.1.1: Type: text/plain, Size: 1742 bytes --]
On Sun Jul 6, 2025 at 8:20 AM CEST, Aditya Garg wrote:
> I don't think we should add it to email headers. There are many email providers
> which do not allow custom headers in the emails. For example if you are using
> protonmail bridge or any third party protonmail client, the headers are not
> preserved. Similarly, if you are using MS Graph to send emails, headers are
> again not preserved. We should also consider cases when people use Thunderbird,
> Mutt or something similar to send emails, rather than git send-email.
As far as I can tell, this isn't actually true. I looked into it and
protonmail and MS Graph both seem to support custom headers. I have also
verified that mutt will preserve the header when you edit the email
normally with mutt -H. If you're sending an email with Thunderbird, none
of these things are preserved (including From, Subject, etc), and the
best you can hope for is attaching the patch, in which case X-Change-ID
will be preserved unmolested.
Moreover, if the change-id header is lost, it's not the end of the
world, it just degrades to the present-day state of affairs, in which
you cannot use it to associate patches with prior versions.
> The headers IMO should include the standard ones like From, Subject etc.
> Custom headers should be a part of body, just like we do Signed-off-by, Link etc.
Trailers and headers are different. The main point of the change-id
discussion earlier on this list was to avoid adding trailers.
I also suspect that if we added this as an "inbody header" that older
git implementations would ingest the X-Change-ID header into the commit
message, which is not a desirable behavior.
IMO the right way forward is to use a mail header.
[-- Attachment #1.2: 42F3F1862E3CC4B8.asc --]
[-- Type: application/pgp-keys, Size: 644 bytes --]
-----BEGIN PGP PUBLIC KEY BLOCK-----
mDMEZ7Y9kxYJKwYBBAHaRw8BAQdA/pPy6X+nNL5T2QaJKEM08xN/Kz7wFTAZoH5Y
riV9x1m0IERyZXcgRGVWYXVsdCA8ZHJld0BkZGV2YXVsdC5vcmc+iJMEExYKADsC
GwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQSftec33CWynY7sRpFC8/GG
LjzEuAUCZ7Y9wwAKCRBC8/GGLjzEuMEEAP9DH+1LgvTqZDLZ8babB5Cdp5y0ZW+Q
Tx78mh1L8jJd6gEAssmgsImcrZv4adP2UW5RU5BHCe9KUdx0DyV83QwlFAS4OARn
tj2TEgorBgEEAZdVAQUBAQdAGAH9dlaCONoXpmQgHoQgYI2tS+VM3mzU8I2PyVYQ
1GUDAQgHiHgEGBYKACACGwwWIQSftec33CWynY7sRpFC8/GGLjzEuAUCZ7Y91gAK
CRBC8/GGLjzEuHcnAP4yjOiM0yqkST6yXzDUWze7B9Im24F8HVx+wNqcDaDtcAD/
fKQhz0SCPiblO6lc7MFUvlaOz2v87UpUYRhzPdgQqwk=
=emrb
-----END PGP PUBLIC KEY BLOCK-----
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-07-06 10:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 11:29 [PATCH v2 1/2] pretty: add X-Change-ID to mail formats Drew DeVault
2025-07-03 11:29 ` [PATCH v2 2/2] am: import X-Change-ID from email headers Drew DeVault
2025-07-06 3:37 ` [PATCH v2 1/2] pretty: add X-Change-ID to mail formats Jeff King
2025-07-06 10:46 ` Drew DeVault
2025-07-06 6:20 ` Aditya Garg
2025-07-06 10:41 ` Drew DeVault [this message]
2025-07-07 1:30 ` Junio C Hamano
2025-07-07 5:53 ` Junio C Hamano
2025-07-07 6:57 ` Martin von Zweigbergk
2025-07-07 6:59 ` Martin von Zweigbergk
2025-07-07 12:40 ` Junio C Hamano
2025-07-07 7:12 ` Drew DeVault
2025-07-07 7:09 ` Drew DeVault
2025-08-19 17:45 ` Remo Senekowitsch
2025-08-20 7:29 ` Drew DeVault
2025-08-21 0:50 ` Junio C Hamano
2025-08-21 8:52 ` Drew DeVault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB4WQTRHWZN3.3VG20AZDK8VN@ddevault.org \
--to=drew@ddevault$(echo .)org \
--cc=andy.koppe@gmail$(echo .)com \
--cc=gargaditya08@live$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=martinvonz@google$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=ps@pks$(echo .)im \
--cc=remo@buenzli$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox