From: Ben Knoble <ben.knoble@gmail•com>
To: Patrick Steinhardt <ps@pks•im>
Cc: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Subject: Re: [RFC] doc: check-docs and WITH_BREAKING_CHANGES
Date: Tue, 23 Sep 2025 09:30:28 -0400 [thread overview]
Message-ID: <DD6B592F-005D-4F36-9585-003C1C4ADAE5@gmail.com> (raw)
In-Reply-To: <aNJUUxfhM7QYDQGj@pks.im>
> Le 23 sept. 2025 à 04:03, Patrick Steinhardt <ps@pks•im> a écrit :
>
> On Fri, Sep 19, 2025 at 02:33:33PM -0700, Junio C Hamano wrote:
>> Shouldn't we do something like this for breaking builds?
>>
>> Documentation/Makefile pays attention to EXCLUDED_PROGRAMS to
>> pretend that the git-$deprecated.adoc files do not exist
>>
>> -include GIT-EXCLUDED-PROGRAMS
>>
>> MAN1_TXT += $(filter-out \
>> $(patsubst %,%.adoc,$(EXCLUDED_PROGRAMS)) \
>> $(addsuffix .adoc, $(ARTICLES) $(SP_ARTICLES)), \
>> $(wildcard git-*.adoc))
>>
>> but nobody seems to put the removed programs on the list.
>>
>> The dependencies around Documentation/GIT-EXCLUDED-PROGRAMS is still
>> screwed up, I think, but this may be a good first step to straighten
>> it out. If "make -C Documentation" runs lint-docs by default, for
>> example, we may want to tweak the Makefile down there to make
>> link-docs target depend on the GIT-EXCLUDED-PROGRAMS perhaps.
>>
>> diff --git i/Makefile w/Makefile
>> index 893070be76..711cade8fd 100644
>> --- i/Makefile
>> +++ w/Makefile
>
> Curious, but what's up with the "i" and "w" prefixes here? :)
That’s « index » and « working tree » from diff.mnemonicPrefix
next prev parent reply other threads:[~2025-09-23 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 21:33 [RFC] doc: check-docs and WITH_BREAKING_CHANGES Junio C Hamano
2025-09-23 8:03 ` Patrick Steinhardt
2025-09-23 13:30 ` Ben Knoble [this message]
2025-09-23 13:58 ` Patrick Steinhardt
2025-09-23 14:43 ` Junio C Hamano
2025-09-23 14:50 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD6B592F-005D-4F36-9585-003C1C4ADAE5@gmail.com \
--to=ben.knoble@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox